| Message ID | 20180117144644.2302131-1-arnd@arndb.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | IIO: ADC: stm32-dfsdm: remove unused variable | expand |
On 17/01/18 14:46, Arnd Bergmann wrote: > A cleanup left one variable behind that is no longer needed and > can be removed, as shown by the gcc warning: > > drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe': > drivers/iio/adc/stm32-dfsdm-core.c:245:29: error: unused variable 'of_id' [-Werror=unused-variable] > > Fixes: abaca806fd13 ("IIO: ADC: stm32-dfsdm: code optimization") Weird, "git show abaca806fd13" contains this exact hunk. I guess it's actually the subsequent merge commit at fault... Robin. > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/iio/adc/stm32-dfsdm-core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index 84277bcc465f..6290332cfd3f 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -242,7 +242,6 @@ MODULE_DEVICE_TABLE(of, stm32_dfsdm_of_match); > static int stm32_dfsdm_probe(struct platform_device *pdev) > { > struct dfsdm_priv *priv; > - const struct of_device_id *of_id; > const struct stm32_dfsdm_dev_data *dev_data; > struct stm32_dfsdm *dfsdm; > int ret; >
Hi Arnd, On 01/17/2018 03:46 PM, Arnd Bergmann wrote: > A cleanup left one variable behind that is no longer needed and > can be removed, as shown by the gcc warning: > > drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe': > drivers/iio/adc/stm32-dfsdm-core.c:245:29: error: unused variable 'of_id' [-Werror=unused-variable] > > Fixes: abaca806fd13 ("IIO: ADC: stm32-dfsdm: code optimization") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/iio/adc/stm32-dfsdm-core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index 84277bcc465f..6290332cfd3f 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -242,7 +242,6 @@ MODULE_DEVICE_TABLE(of, stm32_dfsdm_of_match); > static int stm32_dfsdm_probe(struct platform_device *pdev) > { > struct dfsdm_priv *priv; > - const struct of_device_id *of_id; > const struct stm32_dfsdm_dev_data *dev_data; > struct stm32_dfsdm *dfsdm; > int ret; > Could you crosscheck? This is included in the patch: https://www.spinics.net/lists/arm-kernel/msg628841.html applied in Mark's branches ( commit abaca806fd13afd069e04e883de8ec75924b0598) Regards Arnaud
On Wed, Jan 17, 2018 at 4:27 PM, Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote: > Hi Arnd, > > On 01/17/2018 03:46 PM, Arnd Bergmann wrote: >> A cleanup left one variable behind that is no longer needed and >> can be removed, as shown by the gcc warning: >> >> drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe': >> drivers/iio/adc/stm32-dfsdm-core.c:245:29: error: unused variable 'of_id' [-Werror=unused-variable] >> >> Fixes: abaca806fd13 ("IIO: ADC: stm32-dfsdm: code optimization") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> --- >> drivers/iio/adc/stm32-dfsdm-core.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c >> index 84277bcc465f..6290332cfd3f 100644 >> --- a/drivers/iio/adc/stm32-dfsdm-core.c >> +++ b/drivers/iio/adc/stm32-dfsdm-core.c >> @@ -242,7 +242,6 @@ MODULE_DEVICE_TABLE(of, stm32_dfsdm_of_match); >> static int stm32_dfsdm_probe(struct platform_device *pdev) >> { >> struct dfsdm_priv *priv; >> - const struct of_device_id *of_id; >> const struct stm32_dfsdm_dev_data *dev_data; >> struct stm32_dfsdm *dfsdm; >> int ret; >> > Could you crosscheck? This is included in the patch: > https://www.spinics.net/lists/arm-kernel/msg628841.html applied in > Mark's branches ( commit abaca806fd13afd069e04e883de8ec75924b0598) The problem appears to have come from a mismerge in commit d84b4c7c706f ("Merge branch 'topic/iio' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into asoc-st-dfsdm"). abaca806fd13 was fine, but when Mark merged it into his branch, it seems there was a conflict because both sides contained a copy of my earlier patch 2353758bc2d4 ("IIO: ADC: stm32-dfsdm: avoid unused-variable warning") and 25140717414c, plus one had your abaca806fd1 patch on top. So my patch is correct, but my the 'Fixes' line in the description is wrong, it should have an explanation about the mismerge. Mark, not sure how you want to proceed from here: if this is a branch that can get rebased, it might be best to do that merge again, or even drop one of the two copies of my earlier patch. Otherwise I can send a new version of the fix with an updated explanation. Arnd
On Wed, Jan 17, 2018 at 09:09:19PM +0100, Arnd Bergmann wrote: > Mark, not sure how you want to proceed from here: if this is a branch > that can get rebased, it might be best to do that merge again, or even > drop one of the two copies of my earlier patch. Otherwise I can send > a new version of the fix with an updated explanation. Please resend with the updated explanation.
diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c index 84277bcc465f..6290332cfd3f 100644 --- a/drivers/iio/adc/stm32-dfsdm-core.c +++ b/drivers/iio/adc/stm32-dfsdm-core.c @@ -242,7 +242,6 @@ MODULE_DEVICE_TABLE(of, stm32_dfsdm_of_match); static int stm32_dfsdm_probe(struct platform_device *pdev) { struct dfsdm_priv *priv; - const struct of_device_id *of_id; const struct stm32_dfsdm_dev_data *dev_data; struct stm32_dfsdm *dfsdm; int ret;
A cleanup left one variable behind that is no longer needed and can be removed, as shown by the gcc warning: drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe': drivers/iio/adc/stm32-dfsdm-core.c:245:29: error: unused variable 'of_id' [-Werror=unused-variable] Fixes: abaca806fd13 ("IIO: ADC: stm32-dfsdm: code optimization") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/iio/adc/stm32-dfsdm-core.c | 1 - 1 file changed, 1 deletion(-) -- 2.9.0