From patchwork Thu Jan 18 21:00:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 125030 Delivered-To: patch@linaro.org Received: by 10.46.64.27 with SMTP id n27csp294664lja; Thu, 18 Jan 2018 13:01:17 -0800 (PST) X-Google-Smtp-Source: ACJfBovU+LBVCSJe22kaNQQBCOOQFY6e93sXHPnOm4SE+HLAHraDa97jbheGgo9CCZgW/MCjT98f X-Received: by 10.99.156.26 with SMTP id f26mr5893479pge.65.1516309277192; Thu, 18 Jan 2018 13:01:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516309277; cv=none; d=google.com; s=arc-20160816; b=avzbXZDnohYkfjt5SPNqxqvq4HF4NFGkp1IuhT5xTFo3efpOecmsnz0+otK3Ansbtg OpjCSNqvVbBbX8SpiDAxi98sZtgfUWfyZkWrqHI6lXYK6ixT1Mkq4oX4iAHkUMc1SXS+ vej98DwCzm5iTA5Bh+aM1IEtqypgoK9AebncJs1u8thuEPikt9safg4xn/+3xh1csH3G eqzTDMRVENBNMvoyIqQbWwYqqA9yk9rgcGKJYcfN3rZZ6zOJ4jQ5H+4cFttChqnBRl0O pTYmCt2vZnn1mpSmvqI3iID3EKhrnltCMqrser7mKb3Ojr7wpSvxUWyPklcMXNFs6klf 2Fmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=lTv4ArTO4xC1oa8a3YjTP6bw6Cg0wBS9cEPYNIUPYuQ=; b=HgNV1Dt+3G5tiixmzbJ/qrTrP7UZKo5bNCXoltNGmd7yADxpDu2fgLB+2AEieXyMIz VbWagj3h5iOv9zvEg5wjKmJsS+4YaCvhVmc+AHgKRY1Pc8nkuWYo/k8cE9rtohuYlTIa zB0b9keNrRD5nqbi0dHcCiQGCm2VveKjx9ZQEyuVWecJMt7A/C62B9htqY8CYrJMypBV n/pEp0Fk6MQ9ix7YeKgx5JSCRAPyQyOeDgwq5+EXqn6ig25H5IfHQvCr9n/lR41CMgSa obytan6Nb6t7JJjV6mvlAH1gbJv1Cs9l6s6jd+hCiq2fd7wtBw6igcgWh+3kqtozz/pE 5FZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=NmQseWU3; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c16si4933770pgu.706.2018.01.18.13.01.16; Thu, 18 Jan 2018 13:01:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=NmQseWU3; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754815AbeARVBP (ORCPT + 10 others); Thu, 18 Jan 2018 16:01:15 -0500 Received: from mail-dm3nam03on0105.outbound.protection.outlook.com ([104.47.41.105]:26547 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754631AbeARVBN (ORCPT ); Thu, 18 Jan 2018 16:01:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lTv4ArTO4xC1oa8a3YjTP6bw6Cg0wBS9cEPYNIUPYuQ=; b=NmQseWU3fIeDI/7k4TuI82Jwy4/4q+nmTy+S70DvyhXcJaWUJ3mFibBasefWqxwLnNWJP1/uD9DaQEOSDztUAEE14bm/Zn0VdOVmd9A2OEK45c97umag7C413VzX6ghrLNO+o9ezXSCH/9zAzrU4I97+jFLHX+i2SZ04bcpdtaY= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0917.namprd21.prod.outlook.com (52.132.132.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.444.7; Thu, 18 Jan 2018 21:01:11 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::6485:b98:d15e:9da7]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::6485:b98:d15e:9da7%2]) with mapi id 15.20.0428.008; Thu, 18 Jan 2018 21:01:11 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "stable-commits@vger.kernel.org" CC: Sumit Semwal , Chris J Arges , Jeff Kirsher , Sasha Levin Subject: [added to the 4.1 stable tree] igb: Workaround for igb i210 firmware issue Thread-Topic: [added to the 4.1 stable tree] igb: Workaround for igb i210 firmware issue Thread-Index: AQHTkJ9OFVAj+MWxrE6jChI6cHC/xA== Date: Thu, 18 Jan 2018 21:00:00 +0000 Message-ID: <20180118205908.3220-71-alexander.levin@microsoft.com> References: <20180118205908.3220-1-alexander.levin@microsoft.com> In-Reply-To: <20180118205908.3220-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [167.220.98.9] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0917; 7:/FPtyzH5Ff7ecAOZx0XiiRWJ6VLETrkiOZcVSdLc5777zlITWCTlMU/LjdSGjUuOE3if6i1k9VybJ2PTAZWWssav6Qn0+2kVqIdupsvvLCVgtbUhwuzCJpyQJhcGQ8BkO4vfnfJ3BxdH59E3yDiUS0svM5w/eZs0O3bqphTfn40jOeacfNGPjWmez9bzRWGsWsTsuRfe6JwEU/mRYH67HyDcgWWZox1SCqVIS5+PmV1Wv/rzxYEJAJdN0AdCB2RM x-ms-office365-filtering-correlation-id: f831ebd2-77c0-47ca-d0ed-08d55eb69aa1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020); SRVR:DM5PR2101MB0917; x-ms-traffictypediagnostic: DM5PR2101MB0917: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040495)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231046)(2400067)(944501161)(10201501046)(6055026)(61426038)(61427038)(6041282)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:DM5PR2101MB0917; BCL:0; PCL:0; RULEID:(100000803126)(100110400120); SRVR:DM5PR2101MB0917; x-forefront-prvs: 05568D1FF7 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(346002)(39860400002)(396003)(376002)(39380400002)(199004)(189003)(39060400002)(53936002)(6512007)(5250100002)(102836004)(107886003)(72206003)(6506007)(5660300001)(2900100001)(6486002)(478600001)(6666003)(14454004)(86612001)(26005)(10290500003)(6346003)(2950100002)(4326008)(2501003)(6436002)(25786009)(97736004)(76176011)(22452003)(8936002)(106356001)(6116002)(3846002)(66066001)(1076002)(36756003)(99286004)(316002)(2906002)(110136005)(54906003)(86362001)(68736007)(305945005)(7736002)(105586002)(3660700001)(3280700002)(81156014)(8676002)(81166006)(10090500001)(22906009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0917; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: hniYfNAbzrFrN5D5wVwlXkoLFOn5mrR4xEG4JCX9eP4EVUfEMYcs/U1/fOXye85s7Fs01T6GNpfry+KTjqizZw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: f831ebd2-77c0-47ca-d0ed-08d55eb69aa1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2018 21:00:00.9160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0917 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sumit Semwal This patch has been added to the stable tree. If you have any objections, please let us know. -- 2.11.0 =============== [ Upstream commit 4e684f59d760a2c7c716bb60190783546e2d08a1 ] Sometimes firmware may not properly initialize I347AT4_PAGE_SELECT causing the probe of an igb i210 NIC to fail. This patch adds an addition zeroing of this register during igb_get_phy_id to workaround this issue. Thanks for Jochen Henneberg for the idea and original patch. Signed-off-by: Chris J Arges Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igb/e1000_phy.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c index c1bb64d8366f..bffbcc085689 100644 --- a/drivers/net/ethernet/intel/igb/e1000_phy.c +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c @@ -83,6 +83,10 @@ s32 igb_get_phy_id(struct e1000_hw *hw) s32 ret_val = 0; u16 phy_id; + /* ensure PHY page selection to fix misconfigured i210 */ + if (hw->mac.type == e1000_i210) + phy->ops.write_reg(hw, I347AT4_PAGE_SELECT, 0); + ret_val = phy->ops.read_reg(hw, PHY_ID1, &phy_id); if (ret_val) goto out;