| Message ID | 20180126062323.12412-1-yselkowi@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | ssp: do not use __ssp_protected_ symbol prefixes | expand |
On Jan 26 00:23, Yaakov Selkowitz wrote: > This is a NetBSD-specific detail which does not apply to Newlib, causing > linking issues in certain scenarios: > > https://cygwin.com/ml/cygwin/2018-01/msg00189.html > > Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com> > --- > Corinna, this should be considered for Cygwin 2.10. > > newlib/libc/include/ssp/ssp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/newlib/libc/include/ssp/ssp.h b/newlib/libc/include/ssp/ssp.h > index 5c65cf4b2..922908659 100644 > --- a/newlib/libc/include/ssp/ssp.h > +++ b/newlib/libc/include/ssp/ssp.h > @@ -51,7 +51,6 @@ > __chk_fail() > #define __ssp_decl(rtype, fun, args) \ > rtype __ssp_real_(fun) args __asm__(__ASMNAME(#fun)); \ > -__ssp_inline rtype fun args __asm__(__ASMNAME("__ssp_protected_" #fun)); \ > __ssp_inline rtype fun args > #define __ssp_redirect_raw(rtype, fun, args, call, cond, bos) \ > __ssp_decl(rtype, fun, args) \ > -- > 2.15.1 Please push. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat
diff --git a/newlib/libc/include/ssp/ssp.h b/newlib/libc/include/ssp/ssp.h index 5c65cf4b2..922908659 100644 --- a/newlib/libc/include/ssp/ssp.h +++ b/newlib/libc/include/ssp/ssp.h @@ -51,7 +51,6 @@ __chk_fail() #define __ssp_decl(rtype, fun, args) \ rtype __ssp_real_(fun) args __asm__(__ASMNAME(#fun)); \ -__ssp_inline rtype fun args __asm__(__ASMNAME("__ssp_protected_" #fun)); \ __ssp_inline rtype fun args #define __ssp_redirect_raw(rtype, fun, args, call, cond, bos) \ __ssp_decl(rtype, fun, args) \
This is a NetBSD-specific detail which does not apply to Newlib, causing linking issues in certain scenarios: https://cygwin.com/ml/cygwin/2018-01/msg00189.html Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com> --- Corinna, this should be considered for Cygwin 2.10. newlib/libc/include/ssp/ssp.h | 1 - 1 file changed, 1 deletion(-) -- 2.15.1