diff mbox

[1/1] spi: omap2-mcspi: remove duplicate inclusion of linux/err.h

Message ID 1353325072-15795-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat Nov. 19, 2012, 11:37 a.m. UTC
linux/err.h was included twice.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/spi/spi-omap2-mcspi.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Shubhrajyoti Datta Nov. 19, 2012, 1:38 p.m. UTC | #1
On Mon, Nov 19, 2012 at 5:07 PM, Sachin Kamat <sachin.kamat@linaro.org>wrote:

> linux/err.h was included twice.
>
Looks good to me.

Wei had also had similar views.

https://lkml.org/lkml/2012/10/7/67


> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/spi/spi-omap2-mcspi.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
> index cc4f2dd..a2cfde6 100644
> --- a/drivers/spi/spi-omap2-mcspi.c
> +++ b/drivers/spi/spi-omap2-mcspi.c
> @@ -39,7 +39,6 @@
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/pinctrl/consumer.h>
> -#include <linux/err.h>
>
>  #include <linux/spi/spi.h>
>
> --
> 1.7.4.1
>
>
>
> ------------------------------------------------------------------------------
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> _______________________________________________
> spi-devel-general mailing list
> spi-devel-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/spi-devel-general
>
Mark Brown Dec. 2, 2012, 3:18 p.m. UTC | #2
On Mon, Nov 19, 2012 at 05:07:52PM +0530, Sachin Kamat wrote:
> linux/err.h was included twice.

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index cc4f2dd..a2cfde6 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -39,7 +39,6 @@ 
 #include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/pinctrl/consumer.h>
-#include <linux/err.h>
 
 #include <linux/spi/spi.h>