diff mbox series

media: i2c: TDA1997x: add CONFIG_SND dependency

Message ID 20180223131356.979530-1-arnd@arndb.de
State Accepted
Commit 15001033f4149162359de0ca2d74b39933358fc3
Headers show
Series media: i2c: TDA1997x: add CONFIG_SND dependency | expand

Commit Message

Arnd Bergmann Feb. 23, 2018, 1:13 p.m. UTC
Without CONFIG_SND, we get a link error:

ERROR: "snd_soc_register_codec" [drivers/media/i2c/tda1997x.ko] undefined!
ERROR: "snd_soc_unregister_codec" [drivers/media/i2c/tda1997x.ko] undefined!
ERROR: "snd_pcm_hw_constraint_minmax" [drivers/media/i2c/tda1997x.ko] undefined!

This adds the same Kconfig dependency that we have in other
media drivers, using 'select SND_PCM' to ensure that we have
can call snd_pcm_hw_constraint_minmax, while depending on
CONFIG_SND_SOC for registering the codec.

Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/media/i2c/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.9.0
diff mbox series

Patch

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 94e32d75d632..a44e8c36f13c 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -59,6 +59,8 @@  config VIDEO_TDA9840
 config VIDEO_TDA1997X
 	tristate "NXP TDA1997x HDMI receiver"
 	depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
+	depends on SND_SOC
+	select SND_PCM
 	---help---
 	  V4L2 subdevice driver for the NXP TDA1997x HDMI receivers.