diff mbox series

[39/47] usb: isp1362: remove blackfin arch glue

Message ID 20180314153603.3127932-40-arnd@arndb.de
State Accepted
Commit da2827a298f8a2159f31466759cbba2dd4f1b65f
Headers show
Series [01/47] edac: remove tile driver | expand

Commit Message

Arnd Bergmann March 14, 2018, 3:35 p.m. UTC
The blackfin architecture is getting removed, and this is the last
remaining architecture specific setting, so the various hacks
can be removed now.

From all I can tell, there are no remaining in-tree users of the
driver, but it could be used by out-of-tree platform ports.
I've marked the driver as 'depends on COMPILE_TEST', short of
removing it outright.

It was originally written for some ARM PXA machines using the same
chip, but that platform never really worked and the code has been
removed a long time ago.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/usb/host/Kconfig   |  1 +
 drivers/usb/host/isp1362.h | 44 --------------------------------------------
 2 files changed, 1 insertion(+), 44 deletions(-)

-- 
2.9.0

Comments

Greg KH March 14, 2018, 4:33 p.m. UTC | #1
On Wed, Mar 14, 2018 at 04:35:52PM +0100, Arnd Bergmann wrote:
> The blackfin architecture is getting removed, and this is the last

> remaining architecture specific setting, so the various hacks

> can be removed now.

> 

> >From all I can tell, there are no remaining in-tree users of the

> driver, but it could be used by out-of-tree platform ports.

> I've marked the driver as 'depends on COMPILE_TEST', short of

> removing it outright.

> 

> It was originally written for some ARM PXA machines using the same

> chip, but that platform never really worked and the code has been

> removed a long time ago.

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  drivers/usb/host/Kconfig   |  1 +

>  drivers/usb/host/isp1362.h | 44 --------------------------------------------

>  2 files changed, 1 insertion(+), 44 deletions(-)


Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff mbox series

Patch

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 4fcfb3084b36..b85822f0c874 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -360,6 +360,7 @@  config USB_ISP116X_HCD
 config USB_ISP1362_HCD
 	tristate "ISP1362 HCD support"
 	depends on HAS_IOMEM
+	depends on COMPILE_TEST # nothing uses this
 	---help---
 	  Supports the Philips ISP1362 chip as a host controller
 
diff --git a/drivers/usb/host/isp1362.h b/drivers/usb/host/isp1362.h
index da79e36ced89..87c1ac97e538 100644
--- a/drivers/usb/host/isp1362.h
+++ b/drivers/usb/host/isp1362.h
@@ -9,47 +9,6 @@ 
 /*
  * Platform specific compile time options
  */
-#if defined(CONFIG_BLACKFIN)
-
-#include <linux/io.h>
-#define USE_32BIT		0
-#define MAX_ROOT_PORTS		2
-#define USE_PLATFORM_DELAY	0
-#define USE_NDELAY		1
-
-#define DUMMY_DELAY_ACCESS \
-	do { \
-		bfin_read16(ASYNC_BANK0_BASE); \
-		bfin_read16(ASYNC_BANK0_BASE); \
-		bfin_read16(ASYNC_BANK0_BASE); \
-	} while (0)
-
-#undef insw
-#undef outsw
-
-#define insw  delayed_insw
-#define outsw  delayed_outsw
-
-static inline void delayed_outsw(unsigned int addr, void *buf, int len)
-{
-	unsigned short *bp = (unsigned short *)buf;
-	while (len--) {
-		DUMMY_DELAY_ACCESS;
-		outw(*bp++, addr);
-	}
-}
-
-static inline void delayed_insw(unsigned int addr, void *buf, int len)
-{
-	unsigned short *bp = (unsigned short *)buf;
-	while (len--) {
-		DUMMY_DELAY_ACCESS;
-		*bp++ = inw(addr);
-	}
-}
-
-#else
-
 #define MAX_ROOT_PORTS		2
 
 #define USE_32BIT		0
@@ -60,9 +19,6 @@  static inline void delayed_insw(unsigned int addr, void *buf, int len)
 
 #define DUMMY_DELAY_ACCESS do {} while (0)
 
-#endif
-
-
 /* ------------------------------------------------------------------------- */
 
 #define USB_RESET_WIDTH			50