[07/13] gpio: ich: Include the right header

Message ID	20180319005056.7380-7-linus.walleij@linaro.org
State	Accepted
Commit	3f4290d4dcf1cfdc242fc4d0874995c3aead72e9
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; From: Linus Walleij <linus.walleij@linaro.org> To: linux-gpio@vger.kernel.org Cc: Linus Walleij <linus.walleij@linaro.org> Subject: [PATCH 07/13] gpio: ich: Include the right header Date: Mon, 19 Mar 2018 01:50:50 +0100 Message-Id: <20180319005056.7380-7-linus.walleij@linaro.org> In-Reply-To: <20180319005056.7380-1-linus.walleij@linaro.org> References: <20180319005056.7380-1-linus.walleij@linaro.org> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk
Series	[01/13] gpio: dln2: Include proper header \| expand [01/13] gpio: dln2: Include proper header [02/13] gpio: ge: Drop of_gpio.h include [03/13] gpio: em: Use the right include [04/13] gpio: ftgpio010: Drop of_gpio.h include [05/13] gpio: grgpio: Include the right header [06/13] gpio: htc-gpio: Include the right header [07/13] gpio: ich: Include the right header [08/13] gpio: ich: Use BIT() macro [09/13] gpio: it87: Include the right header [10/13] gpio: janz-ttl: Include the right header [11/13] gpio: janz-ttl: Use BIT() macro [12/13] gpio: kempld: Include the right header [13/13] gpio: ks8695: Include the right header

Message ID

20180319005056.7380-7-linus.walleij@linaro.org

State

Accepted

Commit

3f4290d4dcf1cfdc242fc4d0874995c3aead72e9

Headers

Received-SPF: pass (google.com: best guess record for domain of
	linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as
	permitted sender) client-ip=209.132.180.67; 
From: Linus Walleij <linus.walleij@linaro.org>
To: linux-gpio@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 07/13] gpio: ich: Include the right header
Date: Mon, 19 Mar 2018 01:50:50 +0100
Message-Id: <20180319005056.7380-7-linus.walleij@linaro.org>
In-Reply-To: <20180319005056.7380-1-linus.walleij@linaro.org>
References: <20180319005056.7380-1-linus.walleij@linaro.org>
Sender: linux-gpio-owner@vger.kernel.org
Precedence: bulk

Series

[01/13] gpio: dln2: Include proper header | expand

Commit Message

Linus Walleij March 19, 2018, 12:50 a.m. UTC

This driver is a pure GPIO driver and should only include
<linux/gpio/driver.h>. Refrain from using GPIOF_* flags in
the driver, just use 1/0 to return direction.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/gpio/gpio-ich.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.14.3

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
index 4f6d643516b7..7a54165d7276 100644
--- a/drivers/gpio/gpio-ich.c
+++ b/drivers/gpio/gpio-ich.c
@@ -23,7 +23,7 @@ 
 #include <linux/ioport.h>
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
 #include <linux/platform_device.h>
 #include <linux/mfd/lpc_ich.h>
 
@@ -176,7 +176,7 @@  static bool ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr)
 
 static int ichx_gpio_get_direction(struct gpio_chip *gpio, unsigned nr)
 {
-	return ichx_read_bit(GPIO_IO_SEL, nr) ? GPIOF_DIR_IN : GPIOF_DIR_OUT;
+	return ichx_read_bit(GPIO_IO_SEL, nr);
 }
 
 static int ichx_gpio_direction_input(struct gpio_chip *gpio, unsigned nr)

[07/13] gpio: ich: Include the right header

Commit Message

Patch