[Xen-devel,for-4.11,v7,05/16] xen/arm: mm: Remove unused relinquish_shared_pages

Message ID 20180403153251.19595-6-julien.grall@arm.com
State Accepted
Commit 61a39cbc1c864d305d1a32025cd8ecc6e0aa91c4
Headers show
Series
  • xen: Convert page_to_mfn and mfn_to_page to use typesafe MFN
Related show

Commit Message

Julien Grall April 3, 2018, 3:32 p.m.
relinquish_shared_pages is never called on Arm.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>

---

Cc: Stefano Stabellini <sstabellini@kernel.org>

    Changes in v6:
        - Add George's reviewed-by

    Changes in v4:
        - Patch added
---
 xen/include/asm-arm/mm.h | 4 ----
 1 file changed, 4 deletions(-)

Comments

Stefano Stabellini April 5, 2018, 8:03 p.m. | #1
On Tue, 3 Apr 2018, Julien Grall wrote:
> relinquish_shared_pages is never called on Arm.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Reviewed-by: George Dunlap <george.dunlap@citrix.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> 
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> 
>     Changes in v6:
>         - Add George's reviewed-by
> 
>     Changes in v4:
>         - Patch added
> ---
>  xen/include/asm-arm/mm.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
> index cabb1daf30..09bec67f63 100644
> --- a/xen/include/asm-arm/mm.h
> +++ b/xen/include/asm-arm/mm.h
> @@ -314,10 +314,6 @@ struct page_info *get_page_from_gva(struct vcpu *v, vaddr_t va,
>                                      unsigned long flags);
>  
>  static inline void put_gfn(struct domain *d, unsigned long gfn) {}
> -static inline int relinquish_shared_pages(struct domain *d)
> -{
> -    return 0;
> -}
>  
>  /*
>   * Arm does not have an M2P, but common code expects a handful of
> -- 
> 2.11.0
>

Patch

diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
index cabb1daf30..09bec67f63 100644
--- a/xen/include/asm-arm/mm.h
+++ b/xen/include/asm-arm/mm.h
@@ -314,10 +314,6 @@  struct page_info *get_page_from_gva(struct vcpu *v, vaddr_t va,
                                     unsigned long flags);
 
 static inline void put_gfn(struct domain *d, unsigned long gfn) {}
-static inline int relinquish_shared_pages(struct domain *d)
-{
-    return 0;
-}
 
 /*
  * Arm does not have an M2P, but common code expects a handful of