| Message ID | dc2584be-e83a-b702-c517-1b78b73099c1@gmail.com |
|---|---|
| State | Accepted |
| Commit | 5b62832c1e5284030500f82d6b3579ceed399fe6 |
| Headers | show |
| Series | tools/memory-model: Update required version of herdtools7 | expand |
On Sun, Apr 08, 2018 at 09:18:08AM +0900, Akira Yokosawa wrote: > >From 64542a47acf159d26b8290480c0af9c2a05d20d6 Mon Sep 17 00:00:00 2001 > From: Akira Yokosawa <akiyks@gmail.com> > Date: Sun, 8 Apr 2018 07:44:55 +0900 > Subject: [PATCH] tools/memory-model: Update required version of herdtools7 > > Code generated by klitmus7 version 7.48 doesn't compile with kernel > header of 4.15 and later due to the absence of ACCESS_ONCE(). > As the issue has been resolved in herdtools7 7.49, bump the required > version number in README. > > Signed-off-by: Akira Yokosawa <akiyks@gmail.com> > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Andrea Parri <parri.andrea@gmail.com> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Boqun Feng <boqun.feng@gmail.com> > Cc: Nicholas Piggin <npiggin@gmail.com> > Cc: David Howells <dhowells@redhat.com> > Cc: Jade Alglave <j.alglave@ucl.ac.uk> > Cc: Luc Maranget <luc.maranget@inria.fr> > Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> > Cc: Ingo Molnar <mingo@redhat.com> > --- > Hi Paul, > > I think this is a 4.17 matter. > Thoughts? Good catch, queued and pushed, thank you! I don't believe that this needs to go into the current merge window, given that there is an easy workaround and that people running into this will likely find your patch via web-seach, at which point they can update their herdtools. But it should definitely go into v4.18! Thanx, Paul > Thanks, Akira > -- > tools/memory-model/README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/memory-model/README b/tools/memory-model/README > index 0b3a5f3..734f7fe 100644 > --- a/tools/memory-model/README > +++ b/tools/memory-model/README > @@ -20,7 +20,7 @@ that litmus test to be exercised within the Linux kernel. > REQUIREMENTS > ============ > > -Version 7.48 of the "herd7" and "klitmus7" tools must be downloaded > +Version 7.49 of the "herd7" and "klitmus7" tools must be downloaded > separately: > > https://github.com/herd/herdtools7 > -- > 2.7.4 >
diff --git a/tools/memory-model/README b/tools/memory-model/README index 0b3a5f3..734f7fe 100644 --- a/tools/memory-model/README +++ b/tools/memory-model/README @@ -20,7 +20,7 @@ that litmus test to be exercised within the Linux kernel. REQUIREMENTS ============ -Version 7.48 of the "herd7" and "klitmus7" tools must be downloaded +Version 7.49 of the "herd7" and "klitmus7" tools must be downloaded separately: https://github.com/herd/herdtools7