From patchwork Mon Dec 3 08:13:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13320 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 7BB2D23E51 for ; Mon, 3 Dec 2012 08:20:34 +0000 (UTC) Received: from mail-ia0-f180.google.com (mail-ia0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 2115AA19CF1 for ; Mon, 3 Dec 2012 08:20:34 +0000 (UTC) Received: by mail-ia0-f180.google.com with SMTP id t4so1861931iag.11 for ; Mon, 03 Dec 2012 00:20:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=P4K3B61vBq1W0sXjhBmgBE/e6vq2AF2oGDgtgsNCLBk=; b=J51uiipZIOiKxKWsFECBmizmlgEg52I7nWjZdCSeObkHrj0ErsJ3Uqmat5MG6dFGha +q0rrxe01XGp8D4PhMwQJhvqnQEUNBWN8FpYrrS9+iWItcazdgQSzUvelq7fwvehiP0N utGXaFNQoInO86ILd/yDNSfSCdm+JWE4LyHpE3ONQRdkNNYcSB4JDVh0TUSoi3ZQn2Xw a5h7k1/bwmzoHg4fnf/NL2a+Oj+hi/kZv3xWKbgOpf9kK749NWT5O3hiBtxmXZgjRxF9 eKKom+dmr+JHspScKZO5I+Lz+E1gGDTKoCiu8HG/IKSrsUAYbu8JQbV0uY/dGehXG4XE 2qgA== Received: by 10.50.42.168 with SMTP id p8mr5485184igl.57.1354522833490; Mon, 03 Dec 2012 00:20:33 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp108087igt; Mon, 3 Dec 2012 00:20:32 -0800 (PST) Received: by 10.68.189.163 with SMTP id gj3mr27187686pbc.110.1354522832614; Mon, 03 Dec 2012 00:20:32 -0800 (PST) Received: from mail-pb0-f45.google.com (mail-pb0-f45.google.com [209.85.160.45]) by mx.google.com with ESMTPS id yl9si18230752pbc.332.2012.12.03.00.20.32 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 03 Dec 2012 00:20:32 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.45 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.45; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.45 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f45.google.com with SMTP id mc8so1702509pbc.4 for ; Mon, 03 Dec 2012 00:20:32 -0800 (PST) Received: by 10.66.78.100 with SMTP id a4mr24155753pax.4.1354522832247; Mon, 03 Dec 2012 00:20:32 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id iu8sm7671943pbc.71.2012.12.03.00.20.28 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 03 Dec 2012 00:20:31 -0800 (PST) From: Sachin Kamat To: alsa-devel@alsa-project.org Cc: lrg@ti.com, broonie@opensource.wolfsonmicro.com, perex@perex.cz, tiwai@suse.de, dchen@diasemi.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] ASoC: da7210: Remove unnecessary regmap_exit call Date: Mon, 3 Dec 2012 13:43:43 +0530 Message-Id: <1354522423-28874-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQlpYuZw4xhZ6Lj7jEGoWel+dh7sdkGDTlWk2tN2U9F5QlKyXxARlyULxV7adhV4CwTJwnji Use of devm_regmap_init_spi does not require an explicit regmap_exit call. Signed-off-by: Sachin Kamat --- sound/soc/codecs/da7210.c | 11 +---------- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c index ab1ee5b..843c1eb 100644 --- a/sound/soc/codecs/da7210.c +++ b/sound/soc/codecs/da7210.c @@ -1337,24 +1337,15 @@ static int __devinit da7210_spi_probe(struct spi_device *spi) if (ret != 0) dev_warn(&spi->dev, "Failed to apply regmap patch: %d\n", ret); - ret = snd_soc_register_codec(&spi->dev, + ret = snd_soc_register_codec(&spi->dev, &soc_codec_dev_da7210, &da7210_dai, 1); - if (ret < 0) - goto err_regmap; - - return ret; - -err_regmap: - regmap_exit(da7210->regmap); return ret; } static int __devexit da7210_spi_remove(struct spi_device *spi) { - struct da7210_priv *da7210 = spi_get_drvdata(spi); snd_soc_unregister_codec(&spi->dev); - regmap_exit(da7210->regmap); return 0; }