diff mbox series

[v2,2/5] dmaengine: sprd: Define the DMA data width type

Message ID a92f8111d23c898c5b696bb3b865e41a20d2f969.1524054807.git.baolin.wang@linaro.org
State Accepted
Commit d7c33cf8ff4e01e12ad854c92512bf76b5291928
Headers show
Series [v2,1/5] dmaengine: sprd: Define the DMA transfer step type | expand

Commit Message

(Exiting) Baolin Wang April 19, 2018, 2 a.m. UTC 
Define the DMA data width type to make code more readable.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>

---
Changes since v1:
- No updates.
---
 drivers/dma/sprd-dma.c |   14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

-- 
1.7.9.5

Comments

Vinod Koul April 27, 2018, 6:25 a.m. UTC | #1 
On Thu, Apr 19, 2018 at 10:00:47AM +0800, Baolin Wang wrote:
> Define the DMA data width type to make code more readable.


Applied this one, thanks
-- 
~Vinod
diff mbox series

Patch

diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index dcfa417..65ff0a58 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -176,6 +176,14 @@  enum sprd_dma_int_type {
 	SPRD_DMA_CFGERR_INT,
 };
 
+/* dma data width values */
+enum sprd_dma_datawidth {
+	SPRD_DMA_DATAWIDTH_1_BYTE,
+	SPRD_DMA_DATAWIDTH_2_BYTES,
+	SPRD_DMA_DATAWIDTH_4_BYTES,
+	SPRD_DMA_DATAWIDTH_8_BYTES,
+};
+
 /* dma channel hardware configuration */
 struct sprd_dma_chn_hw {
 	u32 pause;
@@ -604,15 +612,15 @@  static int sprd_dma_config(struct dma_chan *chan, struct sprd_dma_desc *sdesc,
 	u32 fix_mode = 0, fix_en = 0;
 
 	if (IS_ALIGNED(len, 4)) {
-		datawidth = 2;
+		datawidth = SPRD_DMA_DATAWIDTH_4_BYTES;
 		src_step = SPRD_DMA_WORD_STEP;
 		des_step = SPRD_DMA_WORD_STEP;
 	} else if (IS_ALIGNED(len, 2)) {
-		datawidth = 1;
+		datawidth = SPRD_DMA_DATAWIDTH_2_BYTES;
 		src_step = SPRD_DMA_SHORT_STEP;
 		des_step = SPRD_DMA_SHORT_STEP;
 	} else {
-		datawidth = 0;
+		datawidth = SPRD_DMA_DATAWIDTH_1_BYTE;
 		src_step = SPRD_DMA_BYTE_STEP;
 		des_step = SPRD_DMA_BYTE_STEP;
 	}