| Message ID | 1524147242-220936-1-git-send-email-john.garry@huawei.com |
|---|---|
| State | Accepted |
| Commit | 4b313ca7b661ab8782f3dcb4a8996632a470b4da |
| Headers | show |
| Series | [v2] HISI LPC: Add Kconfig MFD_CORE dependency | expand |
On Thu, Apr 19, 2018 at 4:14 PM, John Garry <john.garry@huawei.com> wrote: > For ACPI support of the HiSilicon LPC driver we depend > on MFD_CORE config. > > Currently the HiSi LPC Kconfig entry does not define this > dependency, so add it. > > The reason for depending on MFD_CORE in the driver is > that we model the LPC host as an MFD, in that a platform > device will be created for each device on the bus. > > We do this as we need to modify the resources of these > derived platform devices, something which we should not > do to the original devices created in the ACPI scan. > Details in e0aa1563f894 ("HISI LPC: Add ACPI support"). > > Fixes: e0aa1563f894 ("HISI LPC: Add ACPI support") > Reported-and-tested-by: Tan Xiaojun <tanxiaojun@huawei.com> > Signed-off-by: John Garry <john.garry@huawei.com> Applied to fixes. Arnd
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig index d1c0b60..6dc177b 100644 --- a/drivers/bus/Kconfig +++ b/drivers/bus/Kconfig @@ -33,6 +33,7 @@ config HISILICON_LPC bool "Support for ISA I/O space on HiSilicon Hip06/7" depends on ARM64 && (ARCH_HISI || COMPILE_TEST) select INDIRECT_PIO + select MFD_CORE if ACPI help Driver to enable I/O access to devices attached to the Low Pin Count bus on the HiSilicon Hip06/7 SoC.
For ACPI support of the HiSilicon LPC driver we depend on MFD_CORE config. Currently the HiSi LPC Kconfig entry does not define this dependency, so add it. The reason for depending on MFD_CORE in the driver is that we model the LPC host as an MFD, in that a platform device will be created for each device on the bus. We do this as we need to modify the resources of these derived platform devices, something which we should not do to the original devices created in the ACPI scan. Details in e0aa1563f894 ("HISI LPC: Add ACPI support"). Fixes: e0aa1563f894 ("HISI LPC: Add ACPI support") Reported-and-tested-by: Tan Xiaojun <tanxiaojun@huawei.com> Signed-off-by: John Garry <john.garry@huawei.com> --- v1->v2 change: - add details of reasong to use MFD to commit message -- 1.9.1