diff mbox

[2/2] ARM: dts: Add keypad row entries for exynos4x12

Message ID 1354788815-21579-2-git-send-email-sachin.kamat@linaro.org
State Superseded
Headers show

Commit Message

Sachin Kamat Dec. 6, 2012, 10:13 a.m. UTC
This patch adds keypad row support for Exynos4x12.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |   56 +++++++++++++++++++++++++++++
 1 files changed, 56 insertions(+), 0 deletions(-)

Comments

Kukjin Kim Dec. 21, 2012, 6:31 p.m. UTC | #1
Sachin Kamat wrote:
> 
> This patch adds keypad row support for Exynos4x12.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |   56
> +++++++++++++++++++++++++++++
>  1 files changed, 56 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> index 0b293fb..bdfdf51 100644
> --- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> @@ -778,6 +778,62 @@
>  			samsung,pin-drv = <3>;
>  		};
> 
> +		keypad_row0: keypad-row0 {
> +			samsung,pins = "gpx2-0";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <3>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		keypad_row1: keypad-row1 {
> +			samsung,pins = "gpx2-1";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <3>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		keypad_row2: keypad-row2 {
> +			samsung,pins = "gpx2-2";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <3>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		keypad_row3: keypad-row3 {
> +			samsung,pins = "gpx2-3";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <3>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		keypad_row4: keypad-row4 {
> +			samsung,pins = "gpx2-4";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <3>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		keypad_row5: keypad-row5 {
> +			samsung,pins = "gpx2-5";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <3>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		keypad_row6: keypad-row6 {
> +			samsung,pins = "gpx2-6";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <3>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		keypad_row7: keypad-row7 {
> +			samsung,pins = "gpx2-7";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <3>;
> +			samsung,pin-drv = <0>;
> +		};
> +
>  		keypad_col0: keypad-col0 {
>  			samsung,pins = "gpx1-0";
>  			samsung,pin-function = <3>;
> --
> 1.7.4.1

No, the nodes for keypad should be defined at each own board dt file.
Because it depends on board not SoC even though some boards can be same each
other.

- Kukjin
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
index 0b293fb..bdfdf51 100644
--- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
@@ -778,6 +778,62 @@ 
 			samsung,pin-drv = <3>;
 		};
 
+		keypad_row0: keypad-row0 {
+			samsung,pins = "gpx2-0";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
+
+		keypad_row1: keypad-row1 {
+			samsung,pins = "gpx2-1";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
+
+		keypad_row2: keypad-row2 {
+			samsung,pins = "gpx2-2";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
+
+		keypad_row3: keypad-row3 {
+			samsung,pins = "gpx2-3";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
+
+		keypad_row4: keypad-row4 {
+			samsung,pins = "gpx2-4";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
+
+		keypad_row5: keypad-row5 {
+			samsung,pins = "gpx2-5";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
+
+		keypad_row6: keypad-row6 {
+			samsung,pins = "gpx2-6";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
+
+		keypad_row7: keypad-row7 {
+			samsung,pins = "gpx2-7";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
+
 		keypad_col0: keypad-col0 {
 			samsung,pins = "gpx1-0";
 			samsung,pin-function = <3>;