| Message ID | 20180509143159.20690-2-rui.silva@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v6,1/2] media: ov2680: dt: Add bindings for OV2680 | expand |
On Wed, May 09, 2018 at 03:31:58PM +0100, Rui Miguel Silva wrote: > Add device tree binding documentation for the OV2680 camera sensor. > > CC: devicetree@vger.kernel.org > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> > --- > .../devicetree/bindings/media/i2c/ov2680.txt | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2680.txt Please add acks/reviewed bys on new versions. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, On Fri 18 May 2018 at 14:18, Rob Herring wrote: > On Wed, May 09, 2018 at 03:31:58PM +0100, Rui Miguel Silva > wrote: >> Add device tree binding documentation for the OV2680 camera >> sensor. >> >> CC: devicetree@vger.kernel.org >> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> >> --- >> .../devicetree/bindings/media/i2c/ov2680.txt | 46 >> +++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/media/i2c/ov2680.txt > > Please add acks/reviewed bys on new versions. I have add this to the cover letter [0]: - Removed Rob Herring Reviewed-by tag, since bindings have changed since his ack. But only now I notice that I did not CC the devicetree list for the all series, but only for this particular patch. Sorry about that. --- Cheers, Rui [0]: https://www.spinics.net/lists/linux-media/msg133942.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 18, 2018 at 10:27 AM, Rui Miguel Silva <rmfrfs@gmail.com> wrote: > Hi Rob, > On Fri 18 May 2018 at 14:18, Rob Herring wrote: >> >> On Wed, May 09, 2018 at 03:31:58PM +0100, Rui Miguel Silva wrote: >>> >>> Add device tree binding documentation for the OV2680 camera sensor. >>> >>> CC: devicetree@vger.kernel.org >>> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> >>> --- >>> .../devicetree/bindings/media/i2c/ov2680.txt | 46 +++++++++++++++++++ >>> 1 file changed, 46 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/media/i2c/ov2680.txt >> >> >> Please add acks/reviewed bys on new versions. > > > I have add this to the cover letter [0]: > - Removed Rob Herring Reviewed-by tag, since bindings have changed since > his > ack. > > But only now I notice that I did not CC the devicetree list for the all > series, but only for this particular patch. Sorry about that. NP. It's better to put this and revision history in the individual patches. I don't always read cover letters anyways. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/media/i2c/ov2680.txt b/Documentation/devicetree/bindings/media/i2c/ov2680.txt new file mode 100644 index 000000000000..11e925ed9dad --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt @@ -0,0 +1,46 @@ +* Omnivision OV2680 MIPI CSI-2 sensor + +Required Properties: +- compatible: should be "ovti,ov2680". +- clocks: reference to the xvclk input clock. +- clock-names: should be "xvclk". +- DOVDD-supply: Digital I/O voltage supply. +- DVDD-supply: Digital core voltage supply. +- AVDD-supply: Analog voltage supply. + +Optional Properties: +- reset-gpios: reference to the GPIO connected to the powerdown/reset pin, + if any. This is an active low signal to the OV2680. + +The device node must contain one 'port' child node for its digital output +video port, and this port must have a single endpoint in accordance with + the video interface bindings defined in +Documentation/devicetree/bindings/media/video-interfaces.txt. + +Endpoint node required properties for CSI-2 connection are: +- remote-endpoint: a phandle to the bus receiver's endpoint node. +- clock-lanes: should be set to <0> (clock lane on hardware lane 0). +- data-lanes: should be set to <1> (one CSI-2 lane supported). + +Example: + +&i2c2 { + ov2680: camera-sensor@36 { + compatible = "ovti,ov2680"; + reg = <0x36>; + clocks = <&osc>; + clock-names = "xvclk"; + reset-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>; + DOVDD-supply = <&sw2_reg>; + DVDD-supply = <&sw2_reg>; + AVDD-supply = <®_peri_3p15v>; + + port { + ov2680_to_mipi: endpoint { + remote-endpoint = <&mipi_from_sensor>; + clock-lanes = <0>; + data-lanes = <1>; + }; + }; + }; +};
Add device tree binding documentation for the OV2680 camera sensor. CC: devicetree@vger.kernel.org Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> --- .../devicetree/bindings/media/i2c/ov2680.txt | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2680.txt -- 2.17.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html