| Message ID | 20180517174718.10107-21-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | fix building of tests/tcg | expand |
On 05/17/2018 12:46 PM, Alex Bennée wrote: > The test-i386 test case is a little special as it includes assembler > files. Add the additional compile magic to assemble these bits and > link them to the final binary. The patch says "add"... > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Reviewed-by: Thomas Huth <thuth@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > --- > tests/tcg/i386/test-i386.c | 1 - > 1 file changed, 1 deletion(-) ...but consists only of a single deletion. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
Eric Blake <eblake@redhat.com> writes: > On 05/17/2018 12:46 PM, Alex Bennée wrote: >> The test-i386 test case is a little special as it includes assembler >> files. Add the additional compile magic to assemble these bits and >> link them to the final binary. > > The patch says "add"... > >> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> Reviewed-by: Thomas Huth <thuth@redhat.com> >> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> >> --- >> tests/tcg/i386/test-i386.c | 1 - >> 1 file changed, 1 deletion(-) > > ...but consists only of a single deletion. Oops, yeah it all got merged into the "move to i386 subdir" patch. Maybe I should just fold that together? -- Alex Bennée
diff --git a/tests/tcg/i386/test-i386.c b/tests/tcg/i386/test-i386.c index 9599204895..cae6a7773a 100644 --- a/tests/tcg/i386/test-i386.c +++ b/tests/tcg/i386/test-i386.c @@ -17,7 +17,6 @@ * along with this program; if not, see <http://www.gnu.org/licenses/>. */ #define _GNU_SOURCE -#include "qemu/compiler.h" #include <stdlib.h> #include <stdio.h> #include <string.h>