diff mbox series

[PULL,19/22] gdbstub: Use qemu_set_cloexec()

Message ID f5bdd781316d2ba140323cb98392e44cac54017d.1526796813.git.mjt@msgid.tls.msk.ru
State Accepted
Commit f5bdd781316d2ba140323cb98392e44cac54017d
Headers show
Series None | expand

Commit Message

Michael Tokarev May 20, 2018, 6:15 a.m. UTC 
From: Peter Maydell <peter.maydell@linaro.org>


Use the utility routine qemu_set_cloexec() rather than
manually calling fcntl(). This lets us drop the #ifndef _WIN32
guards and also means Coverity doesn't complain that we're
ignoring the fcntl error return (CID 1005665, CID 1005667).

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Thomas Huth <thuth@redhat.com>

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

---
 gdbstub.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

-- 
2.11.0
diff mbox series

Patch

diff --git a/gdbstub.c b/gdbstub.c
index 9682e16ef7..b99980d2e2 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1828,9 +1828,7 @@  static void gdb_accept(void)
             perror("accept");
             return;
         } else if (fd >= 0) {
-#ifndef _WIN32
-            fcntl(fd, F_SETFD, FD_CLOEXEC);
-#endif
+            qemu_set_cloexec(fd);
             break;
         }
     }
@@ -1857,9 +1855,7 @@  static int gdbserver_open(int port)
         perror("socket");
         return -1;
     }
-#ifndef _WIN32
-    fcntl(fd, F_SETFD, FD_CLOEXEC);
-#endif
+    qemu_set_cloexec(fd);
 
     socket_set_fast_reuse(fd);