| Message ID | 20180528155858.2966723-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 485aa74a8e94d6ca7360a2fa75539d2e312815bf |
| Headers | show |
| Series | platform: chrome: Add input dependency for tablet switch driver | expand |
Hi Arnd, On Mon, May 28, 2018 at 05:58:46PM +0200, Arnd Bergmann wrote: > Without CONFIG_INPUT, or with a modular input layer and built-in > tablet driver, we get a link error: > > ERROR: "input_event" [drivers/platform/chrome/chromeos_tbmc.ko] undefined! > ERROR: "input_register_device" [drivers/platform/chrome/chromeos_tbmc.ko] undefined! > ERROR: "input_set_capability" [drivers/platform/chrome/chromeos_tbmc.ko] undefined! > ERROR: "devm_input_allocate_device" [drivers/platform/chrome/chromeos_tbmc.ko] undefined! > > This adds the corresponding Kconfig dependency > > Fixes: b418f74170d7 ("platform: chrome: Add Tablet Switch ACPI driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks for the catch! Applied for 4.18. Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org
diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig index 57aabe6e94a3..cb0df9eb3e0f 100644 --- a/drivers/platform/chrome/Kconfig +++ b/drivers/platform/chrome/Kconfig @@ -41,6 +41,7 @@ config CHROMEOS_PSTORE config CHROMEOS_TBMC tristate "ChromeOS Tablet Switch Controller" depends on ACPI + depends on INPUT help This option adds a driver for the tablet switch on select Chrome OS systems.
Without CONFIG_INPUT, or with a modular input layer and built-in tablet driver, we get a link error: ERROR: "input_event" [drivers/platform/chrome/chromeos_tbmc.ko] undefined! ERROR: "input_register_device" [drivers/platform/chrome/chromeos_tbmc.ko] undefined! ERROR: "input_set_capability" [drivers/platform/chrome/chromeos_tbmc.ko] undefined! ERROR: "devm_input_allocate_device" [drivers/platform/chrome/chromeos_tbmc.ko] undefined! This adds the corresponding Kconfig dependency Fixes: b418f74170d7 ("platform: chrome: Add Tablet Switch ACPI driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/platform/chrome/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0