From patchwork Tue May 29 15:43:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 137183 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp4212571lji; Tue, 29 May 2018 08:44:31 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq/rpRLAZOhvaOL/3ThwvDV0fwHMX8Op2O5DpTXwbRyJIch0mv9edvbL1pVaeSxFakVf4Cj X-Received: by 2002:a65:5288:: with SMTP id y8-v6mr14407877pgp.69.1527608671771; Tue, 29 May 2018 08:44:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527608671; cv=none; d=google.com; s=arc-20160816; b=ynjuNkRBmKur1EFV9Oo+vecg4YbnPvzwtO34chWtV1gFS5+3KEIxCoz5u2Q7zvutvG FxYWDL/mw8DLv+3crwh835JZDJZPxQvDWqvybxpMzOR5ZKCHHb6nWTJsH5uAjqNE560b nP6NK9h9dWD+GcaynGbaBy1etr9rKfvIuawA7zHarppQzCs0nEtTog07oGv4IdG/4Vd0 d0emFU8lOgfuQ6zmplXSuF43lkvu47rBKrQ39OKZg+tXYueacG7sVXDTaMddAdqm14tK e2xCP/3PVEIzL3eLC7MThE7J9efYEJ/Ed/S60YJVzCI0/cdCJQmA4p2STvEJZ41a7yEa lG3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=mvnZaW+9DU6Q8s7XclYHZv8MXUruZYwECFgresxVNjE=; b=pL20ZbxoyswRCl20RatgAbl7+hfEb1cF+3SHSZZpsEcdgqhiBQ5bBzbifUS5fkplRk DZ1xobQaCV4YjFDneTeovC9kL9HImYuoZsDSOxwTVvvFTg8Cuirnbw/1VWxP1s8GjG9E vzQeY4lmqJAQBXWmqGSFEu1mWZcY01wQ/BQh+kvhH3YDMkbHxz7O73wsXWmEBfxASmza LWY7sPImFJeptaijL5qXxIomrQKYX0ddO0RQXbsx6vtBX0Yp0A0H8oKlBNtc93AlRda3 81XqxOv4MYpUYd9SJBF/YRjgIw9EXQgSek4sQz4AwNwhk5gspfqGpk1Zoyw1BT16W3i+ moSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x15-v6si26644335pgq.442.2018.05.29.08.44.31; Tue, 29 May 2018 08:44:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936865AbeE2Po3 (ORCPT + 30 others); Tue, 29 May 2018 11:44:29 -0400 Received: from foss.arm.com ([217.140.101.70]:43446 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964812AbeE2PoR (ORCPT ); Tue, 29 May 2018 11:44:17 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4163515AD; Tue, 29 May 2018 08:44:17 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E14D73F25D; Tue, 29 May 2018 08:44:15 -0700 (PDT) From: Mark Rutland To: linux-kernel@vger.kernel.org Cc: Mark Rutland , Boqun Feng , Will Deacon , Richard Henderson , Ivan Kokshaysky , Matt Turner Subject: [PATCHv2 07/16] atomics/alpha: define atomic64_fetch_add_unless() Date: Tue, 29 May 2018 16:43:37 +0100 Message-Id: <20180529154346.3168-8-mark.rutland@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180529154346.3168-1-mark.rutland@arm.com> References: <20180529154346.3168-1-mark.rutland@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As a step towards unifying the atomic/atomic64/atomic_long APIs, this patch converts the arch/alpha implementation of atomic64_add_unless() into an implementation of atomic64_fetch_add_unless(). A wrapper in will build atomic_add_unless() atop of this, provided it is given a preprocessor definition. No functional change is intended as a result of this patch. Signed-off-by: Mark Rutland Acked-by: Peter Zijlstra (Intel) Cc: Boqun Feng Cc: Will Deacon Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner --- arch/alpha/include/asm/atomic.h | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) -- 2.11.0 diff --git a/arch/alpha/include/asm/atomic.h b/arch/alpha/include/asm/atomic.h index 4a800a3424a3..dcb7bbeeae02 100644 --- a/arch/alpha/include/asm/atomic.h +++ b/arch/alpha/include/asm/atomic.h @@ -238,35 +238,36 @@ static __inline__ int atomic_fetch_add_unless(atomic_t *v, int a, int u) #define atomic_fetch_add_unless atomic_fetch_add_unless /** - * atomic64_add_unless - add unless the number is a given value + * atomic64_fetch_add_unless - add unless the number is a given value * @v: pointer of type atomic64_t * @a: the amount to add to v... * @u: ...unless v is equal to u. * * Atomically adds @a to @v, so long as it was not @u. - * Returns true iff @v was not @u. + * Returns the old value of @v. */ -static __inline__ int atomic64_add_unless(atomic64_t *v, long a, long u) +static __inline__ int atomic64_fetch_add_unless(atomic64_t *v, long a, long u) { - long c, tmp; + long c, new, old; smp_mb(); __asm__ __volatile__( - "1: ldq_l %[tmp],%[mem]\n" - " cmpeq %[tmp],%[u],%[c]\n" - " addq %[tmp],%[a],%[tmp]\n" + "1: ldq_l %[old],%[mem]\n" + " cmpeq %[old],%[u],%[c]\n" + " addq %[old],%[a],%[new]\n" " bne %[c],2f\n" - " stq_c %[tmp],%[mem]\n" - " beq %[tmp],3f\n" + " stq_c %[new],%[mem]\n" + " beq %[new],3f\n" "2:\n" ".subsection 2\n" "3: br 1b\n" ".previous" - : [tmp] "=&r"(tmp), [c] "=&r"(c) + : [old] "=&r"(old), [new] "=&r"(new), [c] "=&r"(c) : [mem] "m"(*v), [a] "rI"(a), [u] "rI"(u) : "memory"); smp_mb(); - return !c; + return old; } +#define atomic64_fetch_add_unless atomic64_fetch_add_unless /* * atomic64_dec_if_positive - decrement by 1 if old value positive