From patchwork Tue May 29 15:43:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 137184 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp4212625lji; Tue, 29 May 2018 08:44:34 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJXzfR0JBTZPD8PIFLvg9kZZmTss80I6YyVAwL7pGGAweIO9MGSwC1Hb8lJQhFGa18uFqmb X-Received: by 2002:a62:a09c:: with SMTP id p28-v6mr12605887pfl.9.1527608674757; Tue, 29 May 2018 08:44:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527608674; cv=none; d=google.com; s=arc-20160816; b=oWbPqMlWwqmmhqzELgJSgWD3O71OZogbQnNHcyDkp3GRNSufjG7GEuidGuN9noJ1sL JWFuIbLjBUTTqqd1woRZJw5aEBFd3cr9DMQxQ5lN5PwKEuuyyM1f66TyEuvxvWlbyTDt LbwyXG4RWAzzjA/tvGmoKyjKIzjalUg/3VtTc5VjMsIiZcWWqSmXWuf4MZXMIj8JcJ6T DFHlxL7CjsLiqFOESxEP9OTxSatvJzgYjwZ/en8rzjogZ3Sd94a62Tv757Ac28C7HKIi uTyRPpFzTn2FpRuQ1ltG/0vOjdJFNR+QHPXx6simTbUvMEPyd7cqp2gDk6mQ1hNq11Jr AAzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=dnh+e0RuGiz1NwDjlEVtC69EhEwxFPdRYbJSOl91fqI=; b=tI1FztNfifdwFTv/X0fuifgPnTlrIHh/+VGsmF8wbu7a+wFMHDjO/CNkVmbqfj5XhX FS8Y+0sUn2XBJKTfAYVKg53Xd04v5Blu2icbLGlIZMNNgDqSK/lA7aXrve3v0DZ3Ik4f HKprdzw5Al0rqtKv2msbVvI057IyF8czUAwkEnKmYtcCj4QZsLcNog3NmbWxX+jgKITR PD10wSyrDWtrVPDhqe5N1d/ocGLnoLFbzmD7IZ+QNHu6SxHaomnkpSkBNehm0Uuz6NqF rBctmcxZtZE6we6LL7x3qmpDosHf0U1JkeNlIB/KEQyYHohnFjJNP2MTemYHsecvQMvA gMtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay5-v6si31673104plb.459.2018.05.29.08.44.34; Tue, 29 May 2018 08:44:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964827AbeE2Poc (ORCPT + 30 others); Tue, 29 May 2018 11:44:32 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:43454 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964813AbeE2PoT (ORCPT ); Tue, 29 May 2018 11:44:19 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2998615B2; Tue, 29 May 2018 08:44:19 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1C0F63F25D; Tue, 29 May 2018 08:44:17 -0700 (PDT) From: Mark Rutland To: linux-kernel@vger.kernel.org Cc: Mark Rutland , Boqun Feng , Will Deacon , Vineet Gupta Subject: [PATCHv2 08/16] atomics/arc: define atomic64_fetch_add_unless() Date: Tue, 29 May 2018 16:43:38 +0100 Message-Id: <20180529154346.3168-9-mark.rutland@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180529154346.3168-1-mark.rutland@arm.com> References: <20180529154346.3168-1-mark.rutland@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As a step towards unifying the atomic/atomic64/atomic_long APIs, this patch converts the arch/arc implementation of atomic64_add_unless() into an implementation of atomic64_fetch_add_unless(). A wrapper in will build atomic_add_unless() atop of this, provided it is given a preprocessor definition. No functional change is intended as a result of this patch. Signed-off-by: Mark Rutland Acked-by: Peter Zijlstra (Intel) Cc: Boqun Feng Cc: Will Deacon Cc: Vineet Gupta --- arch/arc/include/asm/atomic.h | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) -- 2.11.0 diff --git a/arch/arc/include/asm/atomic.h b/arch/arc/include/asm/atomic.h index 60da80481c5d..335ddc21ed03 100644 --- a/arch/arc/include/asm/atomic.h +++ b/arch/arc/include/asm/atomic.h @@ -531,41 +531,40 @@ static inline long long atomic64_dec_if_positive(atomic64_t *v) } /** - * atomic64_add_unless - add unless the number is a given value + * atomic64_fetch_add_unless - add unless the number is a given value * @v: pointer of type atomic64_t * @a: the amount to add to v... * @u: ...unless v is equal to u. * - * if (v != u) { v += a; ret = 1} else {ret = 0} - * Returns 1 iff @v was not @u (i.e. if add actually happened) + * Atomically adds @a to @v, so long as it was not @u. + * Returns the old value of @v */ -static inline int atomic64_add_unless(atomic64_t *v, long long a, long long u) +static inline long long atomic64_fetch_add_unless(atomic64_t *v, long long a, + long long u) { - long long val; - int op_done; + long long old, temp; smp_mb(); __asm__ __volatile__( "1: llockd %0, [%2] \n" - " mov %1, 1 \n" " brne %L0, %L4, 2f # continue to add since v != u \n" " breq.d %H0, %H4, 3f # return since v == u \n" - " mov %1, 0 \n" "2: \n" - " add.f %L0, %L0, %L3 \n" - " adc %H0, %H0, %H3 \n" - " scondd %0, [%2] \n" + " add.f %L1, %L0, %L3 \n" + " adc %H1, %H0, %H3 \n" + " scondd %1, [%2] \n" " bnz 1b \n" "3: \n" - : "=&r"(val), "=&r" (op_done) + : "=&r"(old), "=&r" (temp) : "r"(&v->counter), "r"(a), "r"(u) : "cc"); /* memory clobber comes from smp_mb() */ smp_mb(); - return op_done; + return old; } +#define atomic64_fetch_add_unless atomic64_fetch_add_unless #define atomic64_add_negative(a, v) (atomic64_add_return((a), (v)) < 0) #define atomic64_inc(v) atomic64_add(1LL, (v))