| Message ID | 20180530213406.618544-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 822852f203f75f929cd90eb196c0f7ca17efe6b1 |
| Headers | show |
| Series | phy: tegra: select USB_COMMON | expand |
On 31.05.2018 00:33, Arnd Bergmann wrote: > A built-in PHY driver cannot link against modular USB core code: > > drivers/usb/phy/phy-tegra-usb.o: In function `tegra_usb_phy_probe': > phy-tegra-usb.c:(.text+0x6bc): undefined reference to `usb_get_dr_mode' > > This uses a 'select' statement in Kconfig like we have for other such > PHY drivers. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/usb/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig > index b9b0a44be679..d7312eed6088 100644 > --- a/drivers/usb/phy/Kconfig > +++ b/drivers/usb/phy/Kconfig > @@ -162,6 +162,7 @@ config USB_MXS_PHY > config USB_TEGRA_PHY > tristate "NVIDIA Tegra USB PHY Driver" > depends on ARCH_TEGRA > + select USB_COMMON > select USB_PHY > select USB_ULPI > help > Thank you! Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index b9b0a44be679..d7312eed6088 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -162,6 +162,7 @@ config USB_MXS_PHY config USB_TEGRA_PHY tristate "NVIDIA Tegra USB PHY Driver" depends on ARCH_TEGRA + select USB_COMMON select USB_PHY select USB_ULPI help
A built-in PHY driver cannot link against modular USB core code: drivers/usb/phy/phy-tegra-usb.o: In function `tegra_usb_phy_probe': phy-tegra-usb.c:(.text+0x6bc): undefined reference to `usb_get_dr_mode' This uses a 'select' statement in Kconfig like we have for other such PHY drivers. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/usb/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0