| Message ID | 20180605114856.1558554-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | a748ddd1132c79888390934216ef428e0b2f0ea8 |
| Headers | show |
| Series | coresight: include vmalloc.h for vmap/vunmap | expand |
On 5 June 2018 at 05:48, Arnd Bergmann <arnd@arndb.de> wrote: > The newly introduced code fails to build in some configurations > unless we include the right headers: > > drivers/hwtracing/coresight/coresight-tmc-etr.c: In function 'tmc_free_table_pages': > drivers/hwtracing/coresight/coresight-tmc-etr.c:206:3: error: implicit declaration of function 'vunmap'; did you mean 'iounmap'? [-Werror=implicit-function-declaration] > > Fixes: 79613ae8715a ("coresight: Add generic TMC sg table framework") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/hwtracing/coresight/coresight-tmc-etr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c > index 6164eed0b5fe..3556d9a849e9 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > @@ -8,6 +8,7 @@ > #include <linux/dma-mapping.h> > #include <linux/iommu.h> > #include <linux/slab.h> > +#include <linux/vmalloc.h> > #include "coresight-priv.h" > #include "coresight-tmc.h" > Thank you for that - I have picked it up for 4.18-rc1. Mathieu > -- > 2.9.0 >
diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c index 6164eed0b5fe..3556d9a849e9 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -8,6 +8,7 @@ #include <linux/dma-mapping.h> #include <linux/iommu.h> #include <linux/slab.h> +#include <linux/vmalloc.h> #include "coresight-priv.h" #include "coresight-tmc.h"
The newly introduced code fails to build in some configurations unless we include the right headers: drivers/hwtracing/coresight/coresight-tmc-etr.c: In function 'tmc_free_table_pages': drivers/hwtracing/coresight/coresight-tmc-etr.c:206:3: error: implicit declaration of function 'vunmap'; did you mean 'iounmap'? [-Werror=implicit-function-declaration] Fixes: 79613ae8715a ("coresight: Add generic TMC sg table framework") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/hwtracing/coresight/coresight-tmc-etr.c | 1 + 1 file changed, 1 insertion(+) -- 2.9.0