From patchwork Tue Jun 5 16:39:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 137781 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp1181392lji; Tue, 5 Jun 2018 09:42:18 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLguP6T6lUwyCVsNvHnuWc/SeJUju47kJbn2zvR6AG0X8J0ex3WivEEzpZAN5ndVPUxVE6d X-Received: by 2002:a24:b510:: with SMTP id v16-v6mr20203422ite.87.1528216938234; Tue, 05 Jun 2018 09:42:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528216938; cv=none; d=google.com; s=arc-20160816; b=zlKZaN8tUIAWkfQYY1ulcg18ag90mO5x2Yb5ODCMj1H87vb3Eq6AByhRCHPR28IAq+ h8N0FVMVYhDwfo5eFT9K87ejxiSpV70RQkYgXyUSyjpv2qGvItHv19aH7EfeiVXtyR9A rvc8GojdHlzj1FEU+qh1z3I1mRgTJ+VdFxvS+HcqrROgCUgbdDmOWnZK5j86N5KfxTvN lD4qzbK/iTL6BpVo+l+b+VpVbxUNvhgEahGNAZZTCetxdJjU9fYLtwEOPOYIDgvXyJR2 08RLJ5FSJ1/LFR/SnaQ9n4LiyZKozY+Ql0NLEg2vJNYeVF4qscYCPX3K7NTZdLEMoHxL UzOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:message-id:date:to:from :arc-authentication-results; bh=tT8KF1GTv9psNvNQMhyb16O7gE8FLQVSItywMLiA1jc=; b=PmHtdNHzCYAHJF5DhFgvv5waejzQYUhw0TBhQF7ClwRlcqxqaWqkjQzM+98DX6mXtm u8EZ3ncVckVyjucbYjezONZKnGAkvGlDPwCjq+PpW73kLOE4vTI/oAjeRyDjk7Yl5stZ PnbG6zp5jSFmLzHUKfE5mA9aAPkT9Qv6N5g8CgT/ImEj4gOQabuwuKVfOFVdYmwvHK+K 94YA//X6uZP7SBYf+N8NRJYLTUqIA9BOlIEu7NtijZtii82dydc3nBr842QVYmjtyhlY 5ETHlTom0w+/dFMaADevq+efdAd1LU67wJZxmdT5wXbaQz/YTw3rOBjmkBPHKCvYGMJq Gvpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id c82-v6si1914104itg.143.2018.06.05.09.42.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Jun 2018 09:42:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fQEzs-0002Q9-6x; Tue, 05 Jun 2018 16:39:48 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fQEzr-0002Q0-EH for xen-devel@lists.xen.org; Tue, 05 Jun 2018 16:39:47 +0000 X-Inumbo-ID: be3e9528-68de-11e8-9728-bc764e045a96 Received: from foss.arm.com (unknown [217.140.101.70]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTP id be3e9528-68de-11e8-9728-bc764e045a96; Tue, 05 Jun 2018 18:37:31 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22B5C1529; Tue, 5 Jun 2018 09:39:46 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.206.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E29163F557; Tue, 5 Jun 2018 09:39:43 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org, xen-devel@lists.xen.org Date: Tue, 5 Jun 2018 17:39:38 +0100 Message-Id: <20180605163938.28090-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH for-4.11] scripts/add_maintainers.pl: Don't call get_maintainers.pl with -f X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, lars.kurth@citrix.com, Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The option -f of scripts/get_maintainers.pl will return the maintainers of a given file, *not* the list of maintainers if the file was a patch. The output expected of add_maintainers is the latter, so drop the option -f. Signed-off-by: Julien Grall Reviewed-by: Lars.kurth@citrix.com Acked-by: Ian Jackson --- This patch is candidate for Xen 4.11. Without it add_maintainers.pl will not return the correct maintainers. IHMO, it should be fixed ASAP to avoid promoting a broken scripts. --- scripts/add_maintainers.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/add_maintainers.pl b/scripts/add_maintainers.pl index 99e4724112..09e9f6609f 100755 --- a/scripts/add_maintainers.pl +++ b/scripts/add_maintainers.pl @@ -420,7 +420,7 @@ sub ismailinglist ($) { sub getmaintainers ($$$) { my ($file, $rto, $rcc) = @_; my $fh; - open($fh, "-|", $get_maintainer, @get_maintainer_args, '-f', $file) + open($fh, "-|", $get_maintainer, @get_maintainer_args, $file) or die "Failed to open '$get_maintainer'\n"; while(my $line = <$fh>) { chomp $line;