diff mbox series

libvirtd: Add service dependency on systemd-logind

Message ID e88ec70d930fc4047bc281c4c6e9940b1230c097.1528811263.git.crobinso@redhat.com
State Accepted
Commit 9f1b1194b031d528f4b376371282ed61279165b0
Headers show
Series libvirtd: Add service dependency on systemd-logind | expand

Commit Message

Cole Robinson June 12, 2018, 1:47 p.m. UTC
At daemon startup we query logind for host PM support status. Without
a service dependency host startup can trigger libvirtd errors like:

error : virNodeSuspendSupportsTarget:336 : internal error: Cannot probe for
supported suspend types
warning : virQEMUCapsInit:949 : Failed to get host power management
capabilities

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1588288
Signed-off-by: Cole Robinson <crobinso@redhat.com>

---
 src/remote/libvirtd.service.in | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Andrea Bolognani June 12, 2018, 3 p.m. UTC | #1
On Tue, 2018-06-12 at 09:47 -0400, Cole Robinson wrote:
> At daemon startup we query logind for host PM support status. Without

> a service dependency host startup can trigger libvirtd errors like:

> 

> error : virNodeSuspendSupportsTarget:336 : internal error: Cannot probe for

> supported suspend types

> warning : virQEMUCapsInit:949 : Failed to get host power management

> capabilities

> 

> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1588288


Please leave a blank line here.

Some people would argue the Resolves: prefix is pointless and/or
harmful, so consider dropping it. Or, you know, don't :)

> Signed-off-by: Cole Robinson <crobinso@redhat.com>

> ---

>  src/remote/libvirtd.service.in | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in

> index 769702ea75..7f689e08a8 100644

> --- a/src/remote/libvirtd.service.in

> +++ b/src/remote/libvirtd.service.in

> @@ -15,6 +15,7 @@ After=iscsid.service

>  After=apparmor.service

>  After=local-fs.target

>  After=remote-fs.target

> +After=systemd-logind.service

>  After=systemd-machined.service

>  Documentation=man:libvirtd(8)

>  Documentation=https://libvirt.org


Reviewed-by: Andrea Bolognani <abologna@redhat.com>


-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox series

Patch

diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in
index 769702ea75..7f689e08a8 100644
--- a/src/remote/libvirtd.service.in
+++ b/src/remote/libvirtd.service.in
@@ -15,6 +15,7 @@  After=iscsid.service
 After=apparmor.service
 After=local-fs.target
 After=remote-fs.target
+After=systemd-logind.service
 After=systemd-machined.service
 Documentation=man:libvirtd(8)
 Documentation=https://libvirt.org