From patchwork Fri Jun 22 15:33:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Todor Tomov X-Patchwork-Id: 139712 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp1025042lji; Fri, 22 Jun 2018 08:42:57 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIhcUNpfzPgx4wBAJr9EP6PPbgRs5F7YdEYfjEBoxEaB14TrjA5OB9FWHI4fuOnanJG1yIB X-Received: by 2002:a17:902:bb8d:: with SMTP id m13-v6mr2229545pls.46.1529682177722; Fri, 22 Jun 2018 08:42:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529682177; cv=none; d=google.com; s=arc-20160816; b=DTLR/merJHI8qRNkzeU/gpw1tOr75DHi/dh31b6KDfTmXZx77tW83k+tJxAmrpQbe3 /pFHRnjkxbkxcbS55xy3wJubZORbyYoYNc0LasKZVyr2J3nlxbdWvvKp/RPmyE4MICl9 zdbikJ/QBKFvGPgN6Fu82O6q7Qy0FKMUqxTOUu7H5ERfPB62cgccbV07FOUkkKT9zqTv fREH67MiudifgEmlqQ0jZ9nMmoVhrTEjmbirLXDsqWt7Fk1N2Sl/XEeP5o7Troru4c24 a8UVro/HTwC3JwFaH30Gyek4P4CXdF/8cAab3jpGH+ELQyviGNdtCfwppRh21QUgIJyJ kGXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=c2j0Ar+sGRnQhZ84qnrq+W6V1tYFnJXzqZAsdrhPFQc=; b=R8Bs1znURaGOFYjI39fRXJ2Nlda9moFqpQgdaEv2SYr/l1cihdNFDCM/cZ8YvO3InA VequA5WtKOzdEBQ1tUdYjle8Skh4Tg//+O9y6RtHiBhS1p9qYppqB271aHCp1uE/cnni qQxdaIB81gG3mr9hCjx3R3bo+cNI2dkecE8GGnkYH5HhLtAwiXv5idjRP1wVGwk5+AUZ jQs0IrvdK2hKU6GBorrwlRXMoXKZhIcEfoMiJoclmcq6a1vOb/+DXFPmaHwZethAuW4/ xB6lqiZ1TTGHh/UFq17LwXCpaz/kOFCmZsaTyHrYmGNMWZkjlMvllpZZJDVW2qmTCwLc 8bDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f68-v6si6183914pgc.475.2018.06.22.08.42.57; Fri, 22 Jun 2018 08:42:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934171AbeFVPmz (ORCPT + 31 others); Fri, 22 Jun 2018 11:42:55 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:46400 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933933AbeFVPeC (ORCPT ); Fri, 22 Jun 2018 11:34:02 -0400 Received: from mms-0439.qualcomm.mm-sol.com (unknown [37.157.136.206]) by extserv.mm-sol.com (Postfix) with ESMTPSA id 2663E4F882; Fri, 22 Jun 2018 18:33:59 +0300 (EEST) From: Todor Tomov To: mchehab@kernel.org, sakari.ailus@linux.intel.com, hans.verkuil@cisco.com, laurent.pinchart+renesas@ideasonboard.com, linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Todor Tomov Subject: [PATCH 06/32] media: camss: Fix OF node usage Date: Fri, 22 Jun 2018 18:33:15 +0300 Message-Id: <1529681621-9682-7-git-send-email-todor.tomov@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1529681621-9682-1-git-send-email-todor.tomov@linaro.org> References: <1529681621-9682-1-git-send-email-todor.tomov@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_graph_get_next_endpoint increases the refcount of the returned node and decreases the refcount of the passed node. Take this into account and use of_node_put properly. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 45285eb..abf6184 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -296,6 +296,7 @@ static int camss_of_parse_ports(struct device *dev, if (of_device_is_available(node)) notifier->num_subdevs++; + of_node_put(node); size = sizeof(*notifier->subdevs) * notifier->num_subdevs; notifier->subdevs = devm_kzalloc(dev, size, GFP_KERNEL); if (!notifier->subdevs) { @@ -326,16 +327,16 @@ static int camss_of_parse_ports(struct device *dev, } remote = of_graph_get_remote_port_parent(node); - of_node_put(node); - if (!remote) { dev_err(dev, "Cannot get remote parent\n"); + of_node_put(node); return -EINVAL; } csd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE; csd->asd.match.fwnode = of_fwnode_handle(remote); } + of_node_put(node); return notifier->num_subdevs; }