| Message ID | 1530208459-32073-1-git-send-email-prime.zeng@hisilicon.com |
|---|---|
| State | Accepted |
| Commit | 11080bf6c705ca1ebed23417204a73738bd81669 |
| Headers | show |
| Series | usb: ohci: change the NUM_EDs from 8 to 32 | expand |
On 06/28/2018 07:54 PM, Zeng Tao wrote: > For ohci, the maximam supported endpoint number is 32(in and out), and > now we have used (usb_pipeendpoint(pipe) << 1) to index the specified > endpoint descritor, usb_pipeendpoint(pipe) can reach 0xf, so we need > change the NUM_EDs from 8 to 32. > > Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com> > --- > drivers/usb/host/ohci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h > index 2350831..fba78dc 100644 > --- a/drivers/usb/host/ohci.h > +++ b/drivers/usb/host/ohci.h > @@ -359,7 +359,7 @@ typedef struct > } urb_priv_t; > #define URB_DEL 1 > > -#define NUM_EDS 8 /* num of preallocated endpoint descriptors */ > +#define NUM_EDS 32 /* num of preallocated endpoint descriptors */ > > #define NUM_TD 64 /* we need more TDs than EDs */ Is this a bugfix for some recent patch ?
Hi Marek: >-----Original Message----- >From: Marek Vasut [mailto:marex@denx.de] >Sent: Friday, June 29, 2018 4:50 PM >To: Zengtao (B) <prime.zeng@hisilicon.com> >Cc: u-boot@lists.denx.de >Subject: Re: [PATCH] usb: ohci: change the NUM_EDs from 8 to 32 > >On 06/28/2018 07:54 PM, Zeng Tao wrote: >> For ohci, the maximam supported endpoint number is 32(in and out), and >> now we have used (usb_pipeendpoint(pipe) << 1) to index the specified >> endpoint descritor, usb_pipeendpoint(pipe) can reach 0xf, so we need >> change the NUM_EDs from 8 to 32. >> >> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com> >> --- >> drivers/usb/host/ohci.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h index >> 2350831..fba78dc 100644 >> --- a/drivers/usb/host/ohci.h >> +++ b/drivers/usb/host/ohci.h >> @@ -359,7 +359,7 @@ typedef struct >> } urb_priv_t; >> #define URB_DEL 1 >> >> -#define NUM_EDS 8 /* num of preallocated endpoint descriptors */ >> +#define NUM_EDS 32 /* num of preallocated endpoint >descriptors */ >> >> #define NUM_TD 64 /* we need more TDs than EDs */ > >Is this a bugfix for some recent patch ? Yes, this is a bugfix, but the issue is introduced more than 10years ago. > >-- >Best regards, >Marek Vasut
On 06/29/2018 11:47 AM, Zengtao (B) wrote: > Hi Marek: > >> -----Original Message----- >> From: Marek Vasut [mailto:marex@denx.de] >> Sent: Friday, June 29, 2018 4:50 PM >> To: Zengtao (B) <prime.zeng@hisilicon.com> >> Cc: u-boot@lists.denx.de >> Subject: Re: [PATCH] usb: ohci: change the NUM_EDs from 8 to 32 >> >> On 06/28/2018 07:54 PM, Zeng Tao wrote: >>> For ohci, the maximam supported endpoint number is 32(in and out), and >>> now we have used (usb_pipeendpoint(pipe) << 1) to index the specified >>> endpoint descritor, usb_pipeendpoint(pipe) can reach 0xf, so we need >>> change the NUM_EDs from 8 to 32. >>> >>> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com> >>> --- >>> drivers/usb/host/ohci.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h index >>> 2350831..fba78dc 100644 >>> --- a/drivers/usb/host/ohci.h >>> +++ b/drivers/usb/host/ohci.h >>> @@ -359,7 +359,7 @@ typedef struct >>> } urb_priv_t; >>> #define URB_DEL 1 >>> >>> -#define NUM_EDS 8 /* num of preallocated endpoint descriptors */ >>> +#define NUM_EDS 32 /* num of preallocated endpoint >> descriptors */ >>> >>> #define NUM_TD 64 /* we need more TDs than EDs */ >> >> Is this a bugfix for some recent patch ? > > Yes, this is a bugfix, but the issue is introduced more than 10years ago. I presume this shows up on hisilicon soc then ? Anyway, applied
HI Marek: >-----Original Message----- >From: Marek Vasut [mailto:marex@denx.de] >Sent: Friday, June 29, 2018 5:52 PM >To: Zengtao (B) <prime.zeng@hisilicon.com> >Cc: u-boot@lists.denx.de >Subject: Re: [PATCH] usb: ohci: change the NUM_EDs from 8 to 32 > >On 06/29/2018 11:47 AM, Zengtao (B) wrote: >> Hi Marek: >> >>> -----Original Message----- >>> From: Marek Vasut [mailto:marex@denx.de] >>> Sent: Friday, June 29, 2018 4:50 PM >>> To: Zengtao (B) <prime.zeng@hisilicon.com> >>> Cc: u-boot@lists.denx.de >>> Subject: Re: [PATCH] usb: ohci: change the NUM_EDs from 8 to 32 >>> >>> On 06/28/2018 07:54 PM, Zeng Tao wrote: >>>> For ohci, the maximam supported endpoint number is 32(in and out), >>>> and now we have used (usb_pipeendpoint(pipe) << 1) to index the >>>> specified endpoint descritor, usb_pipeendpoint(pipe) can reach 0xf, >>>> so we need change the NUM_EDs from 8 to 32. >>>> >>>> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com> >>>> --- >>>> drivers/usb/host/ohci.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h index >>>> 2350831..fba78dc 100644 >>>> --- a/drivers/usb/host/ohci.h >>>> +++ b/drivers/usb/host/ohci.h >>>> @@ -359,7 +359,7 @@ typedef struct >>>> } urb_priv_t; >>>> #define URB_DEL 1 >>>> >>>> -#define NUM_EDS 8 /* num of preallocated endpoint >descriptors */ >>>> +#define NUM_EDS 32 /* num of preallocated endpoint >>> descriptors */ >>>> >>>> #define NUM_TD 64 /* we need more TDs than EDs */ >>> >>> Is this a bugfix for some recent patch ? >> >> Yes, this is a bugfix, but the issue is introduced more than 10years ago. > >I presume this shows up on hisilicon soc then ? Yes, we see it on our soc. > >Anyway, applied > Thank you. >-- >Best regards, >Marek Vasut
On 06/30/2018 03:10 AM, Zengtao (B) wrote: > HI Marek: > > >> -----Original Message----- >> From: Marek Vasut [mailto:marex@denx.de] >> Sent: Friday, June 29, 2018 5:52 PM >> To: Zengtao (B) <prime.zeng@hisilicon.com> >> Cc: u-boot@lists.denx.de >> Subject: Re: [PATCH] usb: ohci: change the NUM_EDs from 8 to 32 >> >> On 06/29/2018 11:47 AM, Zengtao (B) wrote: >>> Hi Marek: >>> >>>> -----Original Message----- >>>> From: Marek Vasut [mailto:marex@denx.de] >>>> Sent: Friday, June 29, 2018 4:50 PM >>>> To: Zengtao (B) <prime.zeng@hisilicon.com> >>>> Cc: u-boot@lists.denx.de >>>> Subject: Re: [PATCH] usb: ohci: change the NUM_EDs from 8 to 32 >>>> >>>> On 06/28/2018 07:54 PM, Zeng Tao wrote: >>>>> For ohci, the maximam supported endpoint number is 32(in and out), >>>>> and now we have used (usb_pipeendpoint(pipe) << 1) to index the >>>>> specified endpoint descritor, usb_pipeendpoint(pipe) can reach 0xf, >>>>> so we need change the NUM_EDs from 8 to 32. >>>>> >>>>> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com> >>>>> --- >>>>> drivers/usb/host/ohci.h | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h index >>>>> 2350831..fba78dc 100644 >>>>> --- a/drivers/usb/host/ohci.h >>>>> +++ b/drivers/usb/host/ohci.h >>>>> @@ -359,7 +359,7 @@ typedef struct >>>>> } urb_priv_t; >>>>> #define URB_DEL 1 >>>>> >>>>> -#define NUM_EDS 8 /* num of preallocated endpoint >> descriptors */ >>>>> +#define NUM_EDS 32 /* num of preallocated endpoint >>>> descriptors */ >>>>> >>>>> #define NUM_TD 64 /* we need more TDs than EDs */ >>>> >>>> Is this a bugfix for some recent patch ? >>> >>> Yes, this is a bugfix, but the issue is introduced more than 10years ago. >> >> I presume this shows up on hisilicon soc then ? > > Yes, we see it on our soc. OK
diff --git a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h index 2350831..fba78dc 100644 --- a/drivers/usb/host/ohci.h +++ b/drivers/usb/host/ohci.h @@ -359,7 +359,7 @@ typedef struct } urb_priv_t; #define URB_DEL 1 -#define NUM_EDS 8 /* num of preallocated endpoint descriptors */ +#define NUM_EDS 32 /* num of preallocated endpoint descriptors */ #define NUM_TD 64 /* we need more TDs than EDs */
For ohci, the maximam supported endpoint number is 32(in and out), and now we have used (usb_pipeendpoint(pipe) << 1) to index the specified endpoint descritor, usb_pipeendpoint(pipe) can reach 0xf, so we need change the NUM_EDs from 8 to 32. Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com> --- drivers/usb/host/ohci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)