diff mbox series

[4/6] target/arm: Prune a15 features from max

Message ID 20180629001538.11415-5-richard.henderson@linaro.org
State Superseded
Headers show
Series target/arm SVE updates | expand

Commit Message

Richard Henderson June 29, 2018, 12:15 a.m. UTC 
There is no need to re-set these 3 features already
implied by the call to aarch64_a15_initfn.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/arm/cpu.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.17.1

Comments

Philippe Mathieu-Daudé June 29, 2018, 12:39 a.m. UTC | #1 
On 06/28/2018 09:15 PM, Richard Henderson wrote:
> There is no need to re-set these 3 features already

> implied by the call to aarch64_a15_initfn.

> 

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


> ---

>  target/arm/cpu.c | 3 ---

>  1 file changed, 3 deletions(-)

> 

> diff --git a/target/arm/cpu.c b/target/arm/cpu.c

> index aa62315cea..878cc6c7e8 100644

> --- a/target/arm/cpu.c

> +++ b/target/arm/cpu.c

> @@ -1796,9 +1796,6 @@ static void arm_max_initfn(Object *obj)

>           * since we don't correctly set the ID registers to advertise them,

>           */

>          set_feature(&cpu->env, ARM_FEATURE_V8);

> -        set_feature(&cpu->env, ARM_FEATURE_VFP4);

> -        set_feature(&cpu->env, ARM_FEATURE_NEON);

> -        set_feature(&cpu->env, ARM_FEATURE_THUMB2EE);

>          set_feature(&cpu->env, ARM_FEATURE_V8_AES);

>          set_feature(&cpu->env, ARM_FEATURE_V8_SHA1);

>          set_feature(&cpu->env, ARM_FEATURE_V8_SHA256);

>
Peter Maydell June 29, 2018, 8:32 a.m. UTC | #2 
On 29 June 2018 at 01:15, Richard Henderson
<richard.henderson@linaro.org> wrote:
> There is no need to re-set these 3 features already

> implied by the call to aarch64_a15_initfn.

>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  target/arm/cpu.c | 3 ---

>  1 file changed, 3 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>


thanks
-- PMM
diff mbox series

Patch

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index aa62315cea..878cc6c7e8 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1796,9 +1796,6 @@  static void arm_max_initfn(Object *obj)
          * since we don't correctly set the ID registers to advertise them,
          */
         set_feature(&cpu->env, ARM_FEATURE_V8);
-        set_feature(&cpu->env, ARM_FEATURE_VFP4);
-        set_feature(&cpu->env, ARM_FEATURE_NEON);
-        set_feature(&cpu->env, ARM_FEATURE_THUMB2EE);
         set_feature(&cpu->env, ARM_FEATURE_V8_AES);
         set_feature(&cpu->env, ARM_FEATURE_V8_SHA1);
         set_feature(&cpu->env, ARM_FEATURE_V8_SHA256);