From patchwork Sat Jun 30 16:18:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 140685 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2139057ljj; Sat, 30 Jun 2018 09:21:00 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd+iQt68e93w/SXAjbJRbRIK5kVvMeRODYM+BpAC5e/FkC/Nb+nb4ibIpUlSpwB8NGuPodr X-Received: by 2002:a17:902:d896:: with SMTP id b22-v6mr1455961plz.265.1530375660223; Sat, 30 Jun 2018 09:21:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530375660; cv=none; d=google.com; s=arc-20160816; b=Cwf7WHBRObV+yrCO0qoPJuK8PLwIPTYXfSqg9mlsoqjDn2TeKWl8mN7bPyqY8LHCNP gkprhC+05IsBi+T597OaQ7bZt628yjUuEF88mvSELLkelz8m2nSP09BRryUt6VBnjLl8 Whj5YV84UWkxRi42zDmjqfFv2dTc5uJrCm0SzHasZqRpQt9VZdK2Rbt3TQaVyEcYryDg biQgoJv3JMDAOJ+KQ7szzIvB2X/7Fjm7WmP6MkMPxU0yLK75mO5v4W2MwCPQ8VLo9mvc IUlGZkioQCJ6HKYp2/5Xc1gJhRlLm0kD8HEZsR51iUY86oKAOorxl3ofOVK5x2SCV5SI S3Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=hJq7g3g0CwrmubFANUHdHonKFNoumP2irvnjb4uadxk=; b=as80nW0i1yC7UX2K7rEqu3Ht+5oYMVmv+FMn8khnPflZzNliaAsT59tn9NDDk4zXKT HJoQriiSuONx3v8pwcg/y5lv+ASPndkkQOPO5n0GSCSPaTeqztSonocqStN1jq5NFXtx KF1xzw0ioksc9EZpIfiWg71UiBLrf35dkPtn2t+DHos7nIj/Ch8Bevef0e1XJLTVPkw9 nKTh7etD8bixhu+7UD0cOyMXK+Xqp37ez8PThkTENKjoNCqtMKuny+84DeKKXcSgdLPd /A4j3ihAAHdkEiYIp7RFM8s2Kr8L2FaX82Sj2mN551Xgvi4vrnzsjQ75at61TG3SZY/M 3RiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U7slvhpp; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 78-v6si12501422pfb.204.2018.06.30.09.21.00; Sat, 30 Jun 2018 09:21:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U7slvhpp; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbeF3QUe (ORCPT + 9 others); Sat, 30 Jun 2018 12:20:34 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:43655 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751246AbeF3QUc (ORCPT ); Sat, 30 Jun 2018 12:20:32 -0400 Received: by mail-lf0-f66.google.com with SMTP id m12-v6so8372972lfc.10 for ; Sat, 30 Jun 2018 09:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hJq7g3g0CwrmubFANUHdHonKFNoumP2irvnjb4uadxk=; b=U7slvhpp0WIcj9Xl/DINJd5W9r32VKKBu23EKAG4EI8VUv99LnbkWzoHdSbsl6ZoQX +nBu42bIWQaAFMppRzzcTSlUcAR/fOc81WAmD9xqY2UWs9y/v0HxNlkN/ir2XnsPR+xu lANw8GyYo2PbgyjF8fuzNnlGOln9qC98sFDeI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hJq7g3g0CwrmubFANUHdHonKFNoumP2irvnjb4uadxk=; b=lZJYEvVM/jEx9jSdIDa4CjPZvnEwUnPZyvQIlzOCAQhIrlVwUH/2a6bRAKCilndHcO oCAt3H0NnJm9Y+4U5ViIiA2H8fElM8R1oQBkLAC74LDZSNWRsTsaP5gvTzoPBfeO2Wvy GTts3V5qv/wolKJZGSWaSFKv4kdTKBOHjRBNotYQIuOmnpK92Y01yx9zitwrwWPgMh5b HpxtK1r/crEmAIh6m6ja1J/biCe3GuAwtTRiZLrq8VLAeltRNXjUQ5asBd6xVzjDn8Sx T3DTP2TYK7SPHj7CZr6QetuVN51vaikpeNAYwIdbDkf2enfAePUXUKJJteCrw+yFDztS vBTg== X-Gm-Message-State: APt69E1n9c0xu6TerKZYnr+82axTQlkWxcW5aTrvm2XA0c8zbKNbyqKA uK0g5JtMvt09MUXwwSqAMdS13qls4/c= X-Received: by 2002:a19:8f10:: with SMTP id r16-v6mr7387986lfd.92.1530375630683; Sat, 30 Jun 2018 09:20:30 -0700 (PDT) Received: from localhost.localdomain (c-ae7b71d5.014-348-6c756e10.bbcust.telenor.se. [213.113.123.174]) by smtp.gmail.com with ESMTPSA id 93-v6sm2271978lfy.64.2018.06.30.09.20.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 30 Jun 2018 09:20:29 -0700 (PDT) From: Linus Walleij To: netdev@vger.kernel.org, "David S . Miller" , =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: Janos Laube , Paulius Zaleckas , linux-arm-kernel@lists.infradead.org, Hans Ulli Kroll , Florian Fainelli , Linus Walleij Subject: [PATCH net-next 2/5] net: gemini: Improve connection prints Date: Sat, 30 Jun 2018 18:18:03 +0200 Message-Id: <20180630161806.24312-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180630161806.24312-1-linus.walleij@linaro.org> References: <20180630161806.24312-1-linus.walleij@linaro.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Instead of just specify that a PHY is connected at some speed, also specify which one. This is helpful with several PHYs on the system. Signed-off-by: Linus Walleij --- drivers/net/ethernet/cortina/gemini.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) -- 2.17.1 diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index 8fc31723f700..b49ed8964026 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -300,23 +300,26 @@ static void gmac_speed_set(struct net_device *netdev) status.bits.speed = GMAC_SPEED_1000; if (phydev->interface == PHY_INTERFACE_MODE_RGMII) status.bits.mii_rmii = GMAC_PHY_RGMII_1000; - netdev_info(netdev, "connect to RGMII @ 1Gbit\n"); + netdev_info(netdev, "connect %s to RGMII @ 1Gbit\n", + phydev_name(phydev)); break; case 100: status.bits.speed = GMAC_SPEED_100; if (phydev->interface == PHY_INTERFACE_MODE_RGMII) status.bits.mii_rmii = GMAC_PHY_RGMII_100_10; - netdev_info(netdev, "connect to RGMII @ 100 Mbit\n"); + netdev_info(netdev, "connect %s to RGMII @ 100 Mbit\n", + phydev_name(phydev)); break; case 10: status.bits.speed = GMAC_SPEED_10; if (phydev->interface == PHY_INTERFACE_MODE_RGMII) status.bits.mii_rmii = GMAC_PHY_RGMII_100_10; - netdev_info(netdev, "connect to RGMII @ 10 Mbit\n"); + netdev_info(netdev, "connect %s to RGMII @ 10 Mbit\n", + phydev_name(phydev)); break; default: - netdev_warn(netdev, "Not supported PHY speed (%d)\n", - phydev->speed); + netdev_warn(netdev, "Unsupported PHY speed (%d) on %s\n", + phydev->speed, phydev_name(phydev)); } if (phydev->duplex == DUPLEX_FULL) {