[oe,3/4] php: actually enable openssl

Message ID 20180703092018.5018-3-ross.burton@intel.com
State Accepted
Commit ff33f477c7288c8d619a129fdaf49bb57deb6282
Headers show
Series
  • [oe,1/4] phoronix-test-suite: upgrade to 8.0.1
Related show

Commit Message

Ross Burton July 3, 2018, 9:20 a.m.
The PHP recipe depends on OpenSSL but support is disabled unless you pass
--with-openssl.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta-oe/recipes-devtools/php/php.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.11.0

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Khem Raj July 3, 2018, 9:17 p.m. | #1
On 7/3/18 2:20 AM, Ross Burton wrote:
> The PHP recipe depends on OpenSSL but support is disabled unless you pass

> --with-openssl.


perhaps its better to turn it into a PACKAGECONFIG option while you are
at it

> 

> Signed-off-by: Ross Burton <ross.burton@intel.com>

> ---

>  meta-oe/recipes-devtools/php/php.inc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc

> index f262d60d15..258b20e68c 100644

> --- a/meta-oe/recipes-devtools/php/php.inc

> +++ b/meta-oe/recipes-devtools/php/php.inc

> @@ -57,7 +57,7 @@ EXTRA_OECONF = "--enable-mbstring \

>                  --with-config-file-path=${sysconfdir}/php/apache2-php${PHP_MAJOR_VERSION} \

>                  ${@oe.utils.conditional('SITEINFO_ENDIANNESS', 'le', 'ac_cv_c_bigendian_php=no', 'ac_cv_c_bigendian_php=yes', d)} \

>                  ${@bb.utils.contains('PACKAGECONFIG', 'pam', '', 'ac_cv_lib_pam_pam_start=no', d)} \

> -                ${COMMON_EXTRA_OECONF} \

> +                ${COMMON_EXTRA_OECONF} --with-openssl \

>  "

>  

>  CACHED_CONFIGUREVARS += "ac_cv_func_dlopen=yes ac_cv_lib_dl_dlopen=yes"

>
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Andre McCurdy Sept. 4, 2018, 9:13 p.m. | #2
On Tue, Jul 3, 2018 at 2:17 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On 7/3/18 2:20 AM, Ross Burton wrote:

>> The PHP recipe depends on OpenSSL but support is disabled unless you pass

>> --with-openssl.

>

> perhaps its better to turn it into a PACKAGECONFIG option while you are

> at it


It looks like both versions of this patch got merged... so there's
currently an unconditional --with-openssl in EXTRA_OECONF and a
PACKAGECONFIG option too.

>>

>> Signed-off-by: Ross Burton <ross.burton@intel.com>

>> ---

>>  meta-oe/recipes-devtools/php/php.inc | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc

>> index f262d60d15..258b20e68c 100644

>> --- a/meta-oe/recipes-devtools/php/php.inc

>> +++ b/meta-oe/recipes-devtools/php/php.inc

>> @@ -57,7 +57,7 @@ EXTRA_OECONF = "--enable-mbstring \

>>                  --with-config-file-path=${sysconfdir}/php/apache2-php${PHP_MAJOR_VERSION} \

>>                  ${@oe.utils.conditional('SITEINFO_ENDIANNESS', 'le', 'ac_cv_c_bigendian_php=no', 'ac_cv_c_bigendian_php=yes', d)} \

>>                  ${@bb.utils.contains('PACKAGECONFIG', 'pam', '', 'ac_cv_lib_pam_pam_start=no', d)} \

>> -                ${COMMON_EXTRA_OECONF} \

>> +                ${COMMON_EXTRA_OECONF} --with-openssl \

>>  "

>>

>>  CACHED_CONFIGUREVARS += "ac_cv_func_dlopen=yes ac_cv_lib_dl_dlopen=yes"

>>

>

>

>

> --

> _______________________________________________

> Openembedded-devel mailing list

> Openembedded-devel@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

>

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj Sept. 4, 2018, 11:52 p.m. | #3
On Tue, Sep 4, 2018 at 2:13 PM Andre McCurdy <armccurdy@gmail.com> wrote:
>

> On Tue, Jul 3, 2018 at 2:17 PM, Khem Raj <raj.khem@gmail.com> wrote:

> > On 7/3/18 2:20 AM, Ross Burton wrote:

> >> The PHP recipe depends on OpenSSL but support is disabled unless you pass

> >> --with-openssl.

> >

> > perhaps its better to turn it into a PACKAGECONFIG option while you are

> > at it

>

> It looks like both versions of this patch got merged... so there's

> currently an unconditional --with-openssl in EXTRA_OECONF and a

> PACKAGECONFIG option too.


yikes. got lost in v1 and v2, thanks for pointing out. I have reverted it
in kraj/master

>

> >>

> >> Signed-off-by: Ross Burton <ross.burton@intel.com>

> >> ---

> >>  meta-oe/recipes-devtools/php/php.inc | 2 +-

> >>  1 file changed, 1 insertion(+), 1 deletion(-)

> >>

> >> diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc

> >> index f262d60d15..258b20e68c 100644

> >> --- a/meta-oe/recipes-devtools/php/php.inc

> >> +++ b/meta-oe/recipes-devtools/php/php.inc

> >> @@ -57,7 +57,7 @@ EXTRA_OECONF = "--enable-mbstring \

> >>                  --with-config-file-path=${sysconfdir}/php/apache2-php${PHP_MAJOR_VERSION} \

> >>                  ${@oe.utils.conditional('SITEINFO_ENDIANNESS', 'le', 'ac_cv_c_bigendian_php=no', 'ac_cv_c_bigendian_php=yes', d)} \

> >>                  ${@bb.utils.contains('PACKAGECONFIG', 'pam', '', 'ac_cv_lib_pam_pam_start=no', d)} \

> >> -                ${COMMON_EXTRA_OECONF} \

> >> +                ${COMMON_EXTRA_OECONF} --with-openssl \

> >>  "

> >>

> >>  CACHED_CONFIGUREVARS += "ac_cv_func_dlopen=yes ac_cv_lib_dl_dlopen=yes"

> >>

> >

> >

> >

> > --

> > _______________________________________________

> > Openembedded-devel mailing list

> > Openembedded-devel@lists.openembedded.org

> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel

> >

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc
index f262d60d15..258b20e68c 100644
--- a/meta-oe/recipes-devtools/php/php.inc
+++ b/meta-oe/recipes-devtools/php/php.inc
@@ -57,7 +57,7 @@  EXTRA_OECONF = "--enable-mbstring \
                 --with-config-file-path=${sysconfdir}/php/apache2-php${PHP_MAJOR_VERSION} \
                 ${@oe.utils.conditional('SITEINFO_ENDIANNESS', 'le', 'ac_cv_c_bigendian_php=no', 'ac_cv_c_bigendian_php=yes', d)} \
                 ${@bb.utils.contains('PACKAGECONFIG', 'pam', '', 'ac_cv_lib_pam_pam_start=no', d)} \
-                ${COMMON_EXTRA_OECONF} \
+                ${COMMON_EXTRA_OECONF} --with-openssl \
 "
 
 CACHED_CONFIGUREVARS += "ac_cv_func_dlopen=yes ac_cv_lib_dl_dlopen=yes"