| Message ID | 20180709152117.21585-3-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | various docker fixes | expand |
On 07/09/2018 12:21 PM, Alex Bennée wrote: > As we check out we need git installed before we start. We would have > had this based on the heavier qemu:debian9 image but we only use plain > debian:9 here. I first thought "weird, I checked this already" then noticed you rebased on debian:9. 'stretch-slim' is an alias for '9-slim' and should be tinier (the previous RFC image is 323MB). > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>> --- > tests/docker/dockerfiles/debian-tricore-cross.docker | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker b/tests/docker/dockerfiles/debian-tricore-cross.docker > index 898b8dd511..5ba3ca88a7 100644 > --- a/tests/docker/dockerfiles/debian-tricore-cross.docker > +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker > @@ -11,6 +11,9 @@ FROM debian:9 > > MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org> > > +RUN apt-get update && \ > + DEBIAN_FRONTEND=noninteractive apt-get install -yy git > + > RUN git clone --single-branch \ > https://github.com/bkoppelmann/tricore-binutils.git \ > /usr/src/binutils && \ >
On 07/10/2018 05:44 PM, Philippe Mathieu-Daudé wrote: > On 07/09/2018 12:21 PM, Alex Bennée wrote: >> As we check out we need git installed before we start. We would have >> had this based on the heavier qemu:debian9 image but we only use plain >> debian:9 here. > > I first thought "weird, I checked this already" then noticed you rebased > on debian:9. > 'stretch-slim' is an alias for '9-slim' and should be tinier (the > previous RFC image is 323MB). > >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>> --- >> tests/docker/dockerfiles/debian-tricore-cross.docker | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker b/tests/docker/dockerfiles/debian-tricore-cross.docker >> index 898b8dd511..5ba3ca88a7 100644 >> --- a/tests/docker/dockerfiles/debian-tricore-cross.docker >> +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker >> @@ -11,6 +11,9 @@ FROM debian:9 >> >> MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org> >> >> +RUN apt-get update && \ >> + DEBIAN_FRONTEND=noninteractive apt-get install -yy git >> + >> RUN git clone --single-branch \ >> https://github.com/bkoppelmann/tricore-binutils.git \ >> /usr/src/binutils && \ >> Apparently this is not enough: ---> Running in a044a41d4521 Cloning into '/usr/src/binutils'... Configuring for a x86_64-unknown-linux-gnu host. Created "Makefile" in /usr/src/binutils ./configure: 8: /tmp/cNf15/cNf15.pos: cc: not found *** The command 'cc -o conftest -w conftest.c' failed. *** You must set the environment variable CC to a working compiler. subprocess.CalledProcessError: Command '['docker', 'build', '-t', 'qemu:debian-tricore-cross', '-f', '/tmp/docker_build10CkqB/tmpEx12gW.docker', '/tmp/docker_build10CkqB']' returned non-zero exit status 1 make: *** [docker-image-debian-tricore-cross] Error 1
Philippe Mathieu-Daudé <f4bug@amsat.org> writes: > On 07/09/2018 12:21 PM, Alex Bennée wrote: >> As we check out we need git installed before we start. We would have >> had this based on the heavier qemu:debian9 image but we only use plain >> debian:9 here. > > I first thought "weird, I checked this already" then noticed you rebased > on debian:9. > 'stretch-slim' is an alias for '9-slim' and should be tinier (the > previous RFC image is 323MB). Hmm why not just switch to qemu:debian9 as we need the compiler as well? It's not like there will be many users only carrying this image in their docker setup. > >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>> --- >> tests/docker/dockerfiles/debian-tricore-cross.docker | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker b/tests/docker/dockerfiles/debian-tricore-cross.docker >> index 898b8dd511..5ba3ca88a7 100644 >> --- a/tests/docker/dockerfiles/debian-tricore-cross.docker >> +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker >> @@ -11,6 +11,9 @@ FROM debian:9 >> >> MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org> >> >> +RUN apt-get update && \ >> + DEBIAN_FRONTEND=noninteractive apt-get install -yy git >> + >> RUN git clone --single-branch \ >> https://github.com/bkoppelmann/tricore-binutils.git \ >> /usr/src/binutils && \ >> -- Alex Bennée
diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker b/tests/docker/dockerfiles/debian-tricore-cross.docker index 898b8dd511..5ba3ca88a7 100644 --- a/tests/docker/dockerfiles/debian-tricore-cross.docker +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker @@ -11,6 +11,9 @@ FROM debian:9 MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org> +RUN apt-get update && \ + DEBIAN_FRONTEND=noninteractive apt-get install -yy git + RUN git clone --single-branch \ https://github.com/bkoppelmann/tricore-binutils.git \ /usr/src/binutils && \
As we check out we need git installed before we start. We would have had this based on the heavier qemu:debian9 image but we only use plain debian:9 here. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- tests/docker/dockerfiles/debian-tricore-cross.docker | 3 +++ 1 file changed, 3 insertions(+) -- 2.17.1