| Message ID | 20180718084909.1902331-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 83ed7d1fe2d2d4a11b30660dec20168bb473d9c1 |
| Headers | show |
| Series | ipv6: ila: select CONFIG_DST_CACHE | expand |
From: Arnd Bergmann <arnd@arndb.de> Date: Wed, 18 Jul 2018 10:48:56 +0200 > My randconfig builds came across an old missing dependency for ILA: > > ERROR: "dst_cache_set_ip6" [net/ipv6/ila/ila.ko] undefined! > ERROR: "dst_cache_get" [net/ipv6/ila/ila.ko] undefined! > ERROR: "dst_cache_init" [net/ipv6/ila/ila.ko] undefined! > ERROR: "dst_cache_destroy" [net/ipv6/ila/ila.ko] undefined! > > We almost never run into this by accident because randconfig builds > end up selecting DST_CACHE from some other tunnel protocol, and this > one appears to be the only one missing the explicit 'select'. > > From all I can tell, this problem first appeared in linux-4.9 > when dst_cache support got added to ILA. > > Fixes: 79ff2fc31e0f ("ila: Cache a route to translated address") > Cc: Tom Herbert <tom@herbertland.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thanks Arnd.
diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig index 0eff75525da1..b3885ca22d6f 100644 --- a/net/ipv6/Kconfig +++ b/net/ipv6/Kconfig @@ -108,6 +108,7 @@ config IPV6_MIP6 config IPV6_ILA tristate "IPv6: Identifier Locator Addressing (ILA)" depends on NETFILTER + select DST_CACHE select LWTUNNEL ---help--- Support for IPv6 Identifier Locator Addressing (ILA).
My randconfig builds came across an old missing dependency for ILA: ERROR: "dst_cache_set_ip6" [net/ipv6/ila/ila.ko] undefined! ERROR: "dst_cache_get" [net/ipv6/ila/ila.ko] undefined! ERROR: "dst_cache_init" [net/ipv6/ila/ila.ko] undefined! ERROR: "dst_cache_destroy" [net/ipv6/ila/ila.ko] undefined! We almost never run into this by accident because randconfig builds end up selecting DST_CACHE from some other tunnel protocol, and this one appears to be the only one missing the explicit 'select'. From all I can tell, this problem first appeared in linux-4.9 when dst_cache support got added to ILA. Fixes: 79ff2fc31e0f ("ila: Cache a route to translated address") Cc: Tom Herbert <tom@herbertland.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- net/ipv6/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0