From patchwork Mon Jul 23 21:26:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 142652 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp6512876ljj; Mon, 23 Jul 2018 14:26:53 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdEJn7epP6hB16JwRD7R2LPNk03XsZN9SFa3sWFMjSpgbDVOfY84g5tVtTKjfKTOKaey3Uv X-Received: by 2002:a63:e355:: with SMTP id o21-v6mr13963406pgj.251.1532381213861; Mon, 23 Jul 2018 14:26:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532381213; cv=none; d=google.com; s=arc-20160816; b=kayJWxlwaoL5GzVseBqt+TgNTDy25fg95ogqk5U/v93NoT+OaepaVd5rEetibFYOVk t3hJUkE87YVeRG4Y6JIpsFZRWMrzAMSzmfzGqCFLyZe/DVrUVeCib4t4LWsxpujiXfHP WYHgQC/ZqRUkZOkIS8YYCS2Vrag1ldpLqomhE1xQF47X2JlPg1Cf48D69lWW2gISTDKb Bb/SOTvx25G8i1QKgi3jJiJcb2M23fiBqmXfPNxpSw0dfZcFvLkMeUw6ICjMOaK71XxQ EpRT0htsLMB1xsc+Cky6FJfCYMhZ2A6gMut6kZ7HDINZB9DZdRX/ANSyzA5oSs6yn8pU gjug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=GQOwQ2NHgNcvLuTH23UsCktV/9Sse/LTn8dLrxzYYIo=; b=aMh9r2Jr9TPghM6OVYGKchKWTaYffavwXBJcHjSgMkiPSWI/jcN1Vc5dWAGXraM4sJ 9hesy9rnUrg3P4pfjr+MsqddWhLz1jycKZhHXB38WvomvN5Yrn0cH0KPNrhzGHrSuZKD oY3KiCEmQXqxJWD4P9fGjgY5BmrPjXpCj+z6F43SdU+lT8goqay3updQPRshppckoUQS 07v3m7rYWaj+MuaR3MNUISxyd44UlQOKSmGQjxuyfZRYx4WSRww7b86VR5XKqf+z69nD BuoMvR2Kxfbr7C/7hiP2QyDaZkgYW+bVX+SH1oLkgx+MkbaMy2TIUfRJBTQNLhFDGYC/ Mvbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="HHIi/rjW"; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e17-v6si8057136pgv.615.2018.07.23.14.26.53; Mon, 23 Jul 2018 14:26:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="HHIi/rjW"; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388141AbeGWW35 (ORCPT + 5 others); Mon, 23 Jul 2018 18:29:57 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:40227 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388209AbeGWW34 (ORCPT ); Mon, 23 Jul 2018 18:29:56 -0400 Received: by mail-lf1-f66.google.com with SMTP id y200-v6so1503728lfd.7 for ; Mon, 23 Jul 2018 14:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=o7Oc/jmwijNpxWrXdFhQ/BdX4OfuEgoV0xJjMD6tz/M=; b=HHIi/rjWoIa7wDsPm1NWPpYqDdzyHLJteOvkOMuib9rtzUHfJhvw4EE18f9Fx5cvuQ LvonTVzqXq+vrhGENKCa6zUbAJZ9sD50Rm7O5An9iMExKE/O4R7MCaXFx29ovCYVKbJn RTO2gvgPlbM7888u7REGBuzy9L3VizF9ObXUE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=o7Oc/jmwijNpxWrXdFhQ/BdX4OfuEgoV0xJjMD6tz/M=; b=eVpQDqsjw6O3jyf3nT5wJOMRNW4P1+//d8w+Vpuuj378khs1zhnsG20OvCgOG5i90e knNHrJKRssur/HYFYQlUV0+fpXTHzTitQplYtX+lzEb7A1325DzsmYEtD1fyGqXFM7Z2 wzAolrC6pD7P+xe3rjdOUSaZ6o2kFjtKJAzR/5W7DJVCRf+dPYjNhuJ9pHeG6T1SkVuz aZrg+oxvvHi62yZ0Y98Wjra2ldZ+Wh3Xdag9xpDHir6M6HBmpX6YGYzNKTxS6sTdfGaR 9paq50P+kRSitcQPtcNqm4OLjzhyjpIf8IO4CK1epP7NsgzFMGSunbTDhphzvO/ChHSs tv7Q== X-Gm-Message-State: AOUpUlG7yeOrpiqXM5cW11S0FW8a9Xr3qKNRslNEIYYY3VAkW4onencU k5AA2wcGUKNbjnggASWAH0ORrQ== X-Received: by 2002:a19:2043:: with SMTP id g64-v6mr5715338lfg.66.1532381209412; Mon, 23 Jul 2018 14:26:49 -0700 (PDT) Received: from localhost.localdomain (59-201-94-178.pool.ukrtel.net. [178.94.201.59]) by smtp.gmail.com with ESMTPSA id q4-v6sm1990435ljh.36.2018.07.23.14.26.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 14:26:48 -0700 (PDT) From: Ivan Khoronzhuk To: davem@davemloft.net, grygorii.strashko@ti.com Cc: corbet@lwn.net, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, vinicius.gomes@intel.com, henrik@austad.us, jesus.sanchez-palencia@intel.com, ilias.apalodimas@linaro.org, p-varis@ti.com, spatton@ti.com, francois.ozog@linaro.org, yogeshs@ti.com, nsekhar@ti.com, andrew@lunn.ch, Ivan Khoronzhuk Subject: [PATCH v5 net-next 1/6] net: ethernet: ti: cpsw: use cpdma channels in backward order for txq Date: Tue, 24 Jul 2018 00:26:29 +0300 Message-Id: <20180723212634.3219-2-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723212634.3219-1-ivan.khoronzhuk@linaro.org> References: <20180723212634.3219-1-ivan.khoronzhuk@linaro.org> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The cpdma channel highest priority is from hi to lo number. The driver has limited number of descriptors that are shared between number of cpdma channels. Number of queues can be tuned with ethtool, that allows to not spend descriptors on not needed cpdma channels. In AVB usually only 2 tx queues can be enough with rate limitation. The rate limitation can be used only for hi priority queues. Thus, to use only 2 queues the 8 has to be created. It's wasteful. So, in order to allow using only needed number of rate limited tx queues, save resources, and be able to set rate limitation for them, let assign tx cpdma channels in backward order to queues. Reviewed-by: Ilias Apalodimas Reviewed-by: Grygorii Strashko Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) -- 2.17.1 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 00761fe59848..4425b537b9dd 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -968,8 +968,8 @@ static int cpsw_tx_mq_poll(struct napi_struct *napi_tx, int budget) /* process every unprocessed channel */ ch_map = cpdma_ctrl_txchs_state(cpsw->dma); - for (ch = 0, num_tx = 0; ch_map; ch_map >>= 1, ch++) { - if (!(ch_map & 0x01)) + for (ch = 0, num_tx = 0; ch_map & 0xff; ch_map <<= 1, ch++) { + if (!(ch_map & 0x80)) continue; txv = &cpsw->txv[ch]; @@ -2432,7 +2432,7 @@ static int cpsw_update_channels_res(struct cpsw_priv *priv, int ch_num, int rx) void (*handler)(void *, int, int); struct netdev_queue *queue; struct cpsw_vector *vec; - int ret, *ch; + int ret, *ch, vch; if (rx) { ch = &cpsw->rx_ch_num; @@ -2445,7 +2445,8 @@ static int cpsw_update_channels_res(struct cpsw_priv *priv, int ch_num, int rx) } while (*ch < ch_num) { - vec[*ch].ch = cpdma_chan_create(cpsw->dma, *ch, handler, rx); + vch = rx ? *ch : 7 - *ch; + vec[*ch].ch = cpdma_chan_create(cpsw->dma, vch, handler, rx); queue = netdev_get_tx_queue(priv->ndev, *ch); queue->tx_maxrate = 0; @@ -2982,7 +2983,7 @@ static int cpsw_probe(struct platform_device *pdev) u32 slave_offset, sliver_offset, slave_size; const struct soc_device_attribute *soc; struct cpsw_common *cpsw; - int ret = 0, i; + int ret = 0, i, ch; int irq; cpsw = devm_kzalloc(&pdev->dev, sizeof(struct cpsw_common), GFP_KERNEL); @@ -3157,7 +3158,8 @@ static int cpsw_probe(struct platform_device *pdev) if (soc) cpsw->quirk_irq = 1; - cpsw->txv[0].ch = cpdma_chan_create(cpsw->dma, 0, cpsw_tx_handler, 0); + ch = cpsw->quirk_irq ? 0 : 7; + cpsw->txv[0].ch = cpdma_chan_create(cpsw->dma, ch, cpsw_tx_handler, 0); if (IS_ERR(cpsw->txv[0].ch)) { dev_err(priv->dev, "error initializing tx dma channel\n"); ret = PTR_ERR(cpsw->txv[0].ch);