From patchwork Mon Jul 23 21:26:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 142653 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp6512898ljj; Mon, 23 Jul 2018 14:26:55 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcWP2xXiqMS+F//0ao4LgjMuvoETqnrBx4nS5KaWy7QKLZkjg0pUpapiN+AOdI8S6WfviBU X-Received: by 2002:a65:5106:: with SMTP id f6-v6mr13484040pgq.72.1532381215698; Mon, 23 Jul 2018 14:26:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532381215; cv=none; d=google.com; s=arc-20160816; b=wfqas8wcUOzjGYU9e/z7PcgfYbzcm4Df8gnpGqfj1tzwVk68pu3b0sujFJqFI53o5L 7eT4aJg+extFR+PQujTGFmIyCwJh6luDLaDCrA5PrH6eLaEfnZ+rNo69L1zT9dcOUvcT xSoCsvN0qyRP9wUXkc11PhU1IMqAGapzSQrBlI/SgYOvjQ/RbaFmfgqpQXeocScYBZbD OI4Ydq6ARlCMqh1p/LtIeeq+19nR5Jqi/9K8IWTl8F6M4+ApANJrovm95DSotFzSMi1W R0QuCbOi8AkHa+3atKO4C+La/+Fb7Atx7xrWTZLANyrfzb5uISfEFHCaYowST/40IjHs kRRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=BWnA9TPtackrjKCaMt05N18Y1D24d+ieX/rJOln0K9E=; b=zr3bexNSoGowdvNzWqokRHIp05lyCOsVSSXYWZcfE6ql2nOCe7t/JXNU0NwEinn+lj 4z+R3ul9zSMSe61ZopFC2RVZwy/vtqmJR62EVfXaFZqAsIT8a0KR5HkRBTx2wMxRPmiP yh0SQa6i+pMChDk6vJQW241SVuYp22KJEb/fvLUr12L2qmA0uFpfomhKlsU1PrM4XITV BA/sQAHcw/sc5XIDjr/uEVuX/ijdnZs+5SklatuCwpzHlChTO1OW6qQ/JmTfm4LUaWY8 /FJJS079s1YoO9NT6Yw7vJZQW8YNE/NNeeLBkS3R/VPvvWjl0GZs+F9BLeyfa4mM/0Hq T9mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=IVwy7TG7; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c9-v6si1156233pgj.654.2018.07.23.14.26.55; Mon, 23 Jul 2018 14:26:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=IVwy7TG7; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388209AbeGWW37 (ORCPT + 5 others); Mon, 23 Jul 2018 18:29:59 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:43775 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388213AbeGWW36 (ORCPT ); Mon, 23 Jul 2018 18:29:58 -0400 Received: by mail-lf1-f66.google.com with SMTP id m12-v6so1493705lfc.10 for ; Mon, 23 Jul 2018 14:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yBVsh6ID+PsAyzotZUt/Xk6nH1yT1g8qCa+S1iZw298=; b=IVwy7TG7ftfrIEfjwsj/F+Zs7DcjFkdRg1aF2AsiZa4KZsvpJDZSPdOcTxk03eWroy pb/wrVUTfAhSh4txJ2bPUixtqVFctE+Zpi3bW8eUsKd871JtGej67yrPqafOVaczI1cu PuGW6rDhsb7B6byBwmfOaBXQXR4hRoCJq+3Kw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yBVsh6ID+PsAyzotZUt/Xk6nH1yT1g8qCa+S1iZw298=; b=M06hTSByZZFgu67IXkU4jcMD9IXBKurVt0DLUyWy3j6ntP4HBTDTrXPwI8a6LPq8Z+ LfYXCTJuJ34JHpDdFMZ2yvN1MG+Mpczwzy1eoNjkOZoV9YZcXvqkDjkITa2quFi66zgj ohuJXF5bcv9VhsSbHN/gvEaQf+OzfZQmRC57w8tqsg6Fe9+Wm9505Vt+f6EN7fjNWm8U b8pmnDCfDEQBpUXeIV4MCezKZxnhpHwuEFiVPvJZr4ZmFgOLGsUMgr6IZZbX81QSzcad /ETkTwnbp5EjKKDiRILOe7MXc7mmiVGcjt2TMqt0IYth+FhKsVYRgpZDGcA23qm3tEf7 k5LA== X-Gm-Message-State: AOUpUlHvF9C0bg+HNo2mLhDXKBqiKoUsP4eqZlT8HKsHtwcIMcFYL/dQ SCq83NuJspMzKx6TmJsH3ZrpKQ== X-Received: by 2002:a19:9fc8:: with SMTP id i191-v6mr7992213lfe.79.1532381210944; Mon, 23 Jul 2018 14:26:50 -0700 (PDT) Received: from localhost.localdomain (59-201-94-178.pool.ukrtel.net. [178.94.201.59]) by smtp.gmail.com with ESMTPSA id q4-v6sm1990435ljh.36.2018.07.23.14.26.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 14:26:50 -0700 (PDT) From: Ivan Khoronzhuk To: davem@davemloft.net, grygorii.strashko@ti.com Cc: corbet@lwn.net, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, vinicius.gomes@intel.com, henrik@austad.us, jesus.sanchez-palencia@intel.com, ilias.apalodimas@linaro.org, p-varis@ti.com, spatton@ti.com, francois.ozog@linaro.org, yogeshs@ti.com, nsekhar@ti.com, andrew@lunn.ch, Ivan Khoronzhuk Subject: [PATCH v5 net-next 2/6] net: ethernet: ti: cpdma: fit rated channels in backward order Date: Tue, 24 Jul 2018 00:26:30 +0300 Message-Id: <20180723212634.3219-3-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723212634.3219-1-ivan.khoronzhuk@linaro.org> References: <20180723212634.3219-1-ivan.khoronzhuk@linaro.org> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org According to TRM tx rated channels should be in 7..0 order, so correct it. Reviewed-by: Ilias Apalodimas Reviewed-by: Grygorii Strashko Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/davinci_cpdma.c | 31 ++++++++++++------------- 1 file changed, 15 insertions(+), 16 deletions(-) -- 2.17.1 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index 4f1267477aa4..4236dcdd5634 100644 --- a/drivers/net/ethernet/ti/davinci_cpdma.c +++ b/drivers/net/ethernet/ti/davinci_cpdma.c @@ -406,37 +406,36 @@ static int cpdma_chan_fit_rate(struct cpdma_chan *ch, u32 rate, struct cpdma_chan *chan; u32 old_rate = ch->rate; u32 new_rmask = 0; - int rlim = 1; + int rlim = 0; int i; - *prio_mode = 0; for (i = tx_chan_num(0); i < tx_chan_num(CPDMA_MAX_CHANNELS); i++) { chan = ctlr->channels[i]; - if (!chan) { - rlim = 0; + if (!chan) continue; - } if (chan == ch) chan->rate = rate; if (chan->rate) { - if (rlim) { - new_rmask |= chan->mask; - } else { - ch->rate = old_rate; - dev_err(ctlr->dev, "Prev channel of %dch is not rate limited\n", - chan->chan_num); - return -EINVAL; - } - } else { - *prio_mode = 1; - rlim = 0; + rlim = 1; + new_rmask |= chan->mask; + continue; } + + if (rlim) + goto err; } *rmask = new_rmask; + *prio_mode = rlim; return 0; + +err: + ch->rate = old_rate; + dev_err(ctlr->dev, "Upper cpdma ch%d is not rate limited\n", + chan->chan_num); + return -EINVAL; } static u32 cpdma_chan_set_factors(struct cpdma_ctlr *ctlr,