[RESEND,v1,2/2] cpuidle: menu: Dismiss tick impaction on correction factors

Message ID 1533835203-5789-3-git-send-email-leo.yan@linaro.org
State New
Headers show
Series
  • Optimization CPU idle state impacted by tick
Related show

Commit Message

Leo Yan Aug. 9, 2018, 5:20 p.m.
If the idle duration predictor detects the tick is triggered, and with
meeting the condition 'data->next_timer_us > TICK_USEC', it will give a
big compensation for the 'measured' interval; this is purposed to avoid
artificially small correction factor values.  Unfortunately, this still
cannot cover all cases of the tick impaction on correction factors,
e.g. if the predicted next event is less than ITCK_USEC, then all
wakening up by the ticks will be taken as usual case and reducing exit
latency, as results the tick events heavily impacts the correction
factors.  Moreover, the coming tick sometimes is very soon, especially
at the first time when the CPU becomes idle the tick expire time might
be vary, so ticks can introduce big deviation on correction factors.

If idle governor deliberately doesn't stop the tick timer, the tick
event is coming as expected with fixed interval, so the tick event is
predictable; if the tick event is coming early than other normal timer
event and other possible wakeup events, we need to dismiss the tick
impaction on correction factors, this can let the correction factor
array is purely used for other wakeup events correctness rather than
sched tick.

This patch is to check if it's a tick wakeup, it takes the CPU can
stay in the idle state for enough time so it gives high compensation
for the measured' interval, this can avoid tick impaction on the
correction factor array.

Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Leo Yan <leo.yan@linaro.org>

---
 drivers/cpuidle/governors/menu.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

-- 
2.7.4

Comments

Rafael J. Wysocki Aug. 9, 2018, 9:06 p.m. | #1
On Thu, Aug 9, 2018 at 7:20 PM, Leo Yan <leo.yan@linaro.org> wrote:
> If the idle duration predictor detects the tick is triggered, and with

> meeting the condition 'data->next_timer_us > TICK_USEC', it will give a

> big compensation for the 'measured' interval; this is purposed to avoid

> artificially small correction factor values.  Unfortunately, this still

> cannot cover all cases of the tick impaction on correction factors,

> e.g. if the predicted next event is less than ITCK_USEC, then all

> wakening up by the ticks will be taken as usual case and reducing exit

> latency, as results the tick events heavily impacts the correction

> factors.

>

> Moreover, the coming tick sometimes is very soon, especially

> at the first time when the CPU becomes idle the tick expire time might

> be vary, so ticks can introduce big deviation on correction factors.

>

> If idle governor deliberately doesn't stop the tick timer, the tick

> event is coming as expected with fixed interval, so the tick event is

> predictable; if the tick event is coming early than other normal timer

> event and other possible wakeup events, we need to dismiss the tick

> impaction on correction factors, this can let the correction factor

> array is purely used for other wakeup events correctness rather than

> sched tick.

>

> This patch is to check if it's a tick wakeup, it takes the CPU can

> stay in the idle state for enough time so it gives high compensation

> for the measured' interval, this can avoid tick impaction on the

> correction factor array.


Well, again, this is questionable.

Yes, you can remove the tick influence on correction factors this way,
but will the resulting idle duration predictions be actually better
because of that?

Do you have any data to demonstrate the difference?

>

> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>

> Cc: Vincent Guittot <vincent.guittot@linaro.org>

> Signed-off-by: Leo Yan <leo.yan@linaro.org>

> ---

>  drivers/cpuidle/governors/menu.c | 14 ++++++--------

>  1 file changed, 6 insertions(+), 8 deletions(-)

>

> diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c

> index 2ce4068..43cbde3 100644

> --- a/drivers/cpuidle/governors/menu.c

> +++ b/drivers/cpuidle/governors/menu.c

> @@ -525,15 +525,13 @@ static void menu_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)

>          * assume the state was never reached and the exit latency is 0.

>          */

>

> -       if (data->tick_wakeup && data->next_timer_us > TICK_USEC) {

> +       if (data->tick_wakeup) {

>                 /*

> -                * The nohz code said that there wouldn't be any events within

> -                * the tick boundary (if the tick was stopped), but the idle

> -                * duration predictor had a differing opinion.  Since the CPU

> -                * was woken up by a tick (that wasn't stopped after all), the

> -                * predictor was not quite right, so assume that the CPU could

> -                * have been idle long (but not forever) to help the idle

> -                * duration predictor do a better job next time.

> +                * Since the CPU was woken up by a tick (that wasn't stopped

> +                * after all), the predictor was not quite right, so assume


This part of the comment is not valid any more IMO.

The fact that the CPU was woken up by the tick alone doesn't tell you
much about the prediction.  The tick may have not been stopped,
because the nohz code saw timer events within the tick boundary, in
which case the CPU could not be idle very long.  The next_timer_us
check is there to see what the nohz code told us.

> +                * that the CPU could have been idle long (but not forever)

> +                * to help the idle duration predictor do a better job next

> +                * time.

>                  */

>                 measured_us = 9 * MAX_INTERESTING / 10;

>         } else {

> --

Patch

diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index 2ce4068..43cbde3 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -525,15 +525,13 @@  static void menu_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)
 	 * assume the state was never reached and the exit latency is 0.
 	 */
 
-	if (data->tick_wakeup && data->next_timer_us > TICK_USEC) {
+	if (data->tick_wakeup) {
 		/*
-		 * The nohz code said that there wouldn't be any events within
-		 * the tick boundary (if the tick was stopped), but the idle
-		 * duration predictor had a differing opinion.  Since the CPU
-		 * was woken up by a tick (that wasn't stopped after all), the
-		 * predictor was not quite right, so assume that the CPU could
-		 * have been idle long (but not forever) to help the idle
-		 * duration predictor do a better job next time.
+		 * Since the CPU was woken up by a tick (that wasn't stopped
+		 * after all), the predictor was not quite right, so assume
+		 * that the CPU could have been idle long (but not forever)
+		 * to help the idle duration predictor do a better job next
+		 * time.
 		 */
 		measured_us = 9 * MAX_INTERESTING / 10;
 	} else {