| Message ID | 1359825953-15663-9-git-send-email-haojian.zhuang@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
* Haojian Zhuang <haojian.zhuang@linaro.org> [130202 09:30]: > @@ -114,4 +116,10 @@ static inline void pinconf_generic_dump_group(struct pinctrl_dev *pctldev, > return; > } > > +static void pinconf_generic_dump_config(struct pinctrl_dev *pctldev, > + struct seq_file *s, > + unsigned long config) > +{ > + return; > +} > #endif This needs to be static inline void to avoid the following warning: drivers/pinctrl/pinconf.h:122: warning: ‘pinconf_generic_dump_config’ defined but not used Regards, Tony
On 5 February 2013 08:35, Tony Lindgren <tony@atomide.com> wrote: > * Haojian Zhuang <haojian.zhuang@linaro.org> [130202 09:30]: >> @@ -114,4 +116,10 @@ static inline void pinconf_generic_dump_group(struct pinctrl_dev *pctldev, >> return; >> } >> >> +static void pinconf_generic_dump_config(struct pinctrl_dev *pctldev, >> + struct seq_file *s, >> + unsigned long config) >> +{ >> + return; >> +} >> #endif > > This needs to be static inline void to avoid the following warning: > > drivers/pinctrl/pinconf.h:122: warning: ‘pinconf_generic_dump_config’ defined but not used > > Regards, > > Tony Thanks. I'll update it. Regards Haojian
diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c index e5948f8..66e4ae5 100644 --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c @@ -120,4 +120,16 @@ void pinconf_generic_dump_group(struct pinctrl_dev *pctldev, } } +void pinconf_generic_dump_config(struct pinctrl_dev *pctldev, + struct seq_file *s, unsigned long config) +{ + int i; + + for(i = 0; i < ARRAY_SIZE(conf_items); i++) { + if (pinconf_to_config_param(config) != conf_items[i].param) + continue; + seq_printf(s, "%s: 0x%x", conf_items[i].display, + pinconf_to_config_argument(config)); + } +} #endif diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h index e3ed8cb..8023421 100644 --- a/drivers/pinctrl/pinconf.h +++ b/drivers/pinctrl/pinconf.h @@ -98,6 +98,8 @@ void pinconf_generic_dump_pin(struct pinctrl_dev *pctldev, void pinconf_generic_dump_group(struct pinctrl_dev *pctldev, struct seq_file *s, const char *gname); +void pinconf_generic_dump_config(struct pinctrl_dev *pctldev, + struct seq_file *s, unsigned long config); #else static inline void pinconf_generic_dump_pin(struct pinctrl_dev *pctldev, @@ -114,4 +116,10 @@ static inline void pinconf_generic_dump_group(struct pinctrl_dev *pctldev, return; } +static void pinconf_generic_dump_config(struct pinctrl_dev *pctldev, + struct seq_file *s, + unsigned long config) +{ + return; +} #endif
Add the support of dumping pin configuration. Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org> --- drivers/pinctrl/pinconf-generic.c | 12 ++++++++++++ drivers/pinctrl/pinconf.h | 8 ++++++++ 2 files changed, 20 insertions(+)