diff mbox series

[v2,3/3] test: ofnode: test ofnode_by_prop_value()

Message ID 20180820091000.3241-4-jens.wiklander@linaro.org
State Accepted
Commit 9bc7e96a7d918286ddf4502b7dab0c7f43ddc3d3
Headers show
Series Convert fdtdec_setup_memory_banksize() to use livetree | expand

Commit Message

Jens Wiklander Aug. 20, 2018, 9:10 a.m. UTC 
Test ofnode_by_prop_value()

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

---
 test/dm/ofnode.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

-- 
2.17.1

Comments

Simon Glass Aug. 21, 2018, 5:30 p.m. UTC | #1 
On 20 August 2018 at 03:10, Jens Wiklander <jens.wiklander@linaro.org> wrote:
> Test ofnode_by_prop_value()
>
> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> ---
>  test/dm/ofnode.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

Thanks
Simon Glass Sept. 28, 2018, 3:55 p.m. UTC | #2 
On 21 August 2018 at 10:30, Simon Glass <sjg@chromium.org> wrote:
> On 20 August 2018 at 03:10, Jens Wiklander <jens.wiklander@linaro.org> wrote:
>> Test ofnode_by_prop_value()
>>
>> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
>> ---
>>  test/dm/ofnode.c | 27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Thanks

Applied to u-boot-dm, and now in mainline, thanks!
diff mbox series

Patch

diff --git a/test/dm/ofnode.c b/test/dm/ofnode.c
index 8db1f9857f7d..907d1ddbdb6f 100644
--- a/test/dm/ofnode.c
+++ b/test/dm/ofnode.c
@@ -15,3 +15,30 @@  static int dm_test_ofnode_compatible(struct unit_test_state *uts)
 	return 0;
 }
 DM_TEST(dm_test_ofnode_compatible, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+
+static int dm_test_ofnode_by_prop_value(struct unit_test_state *uts)
+{
+	const char propname[] = "compatible";
+	const char propval[] = "denx,u-boot-fdt-test";
+	const char *str;
+	ofnode node = ofnode_null();
+
+	/* Find first matching node, there should be at least one */
+	node = ofnode_by_prop_value(node, propname, propval, sizeof(propval));
+	ut_assert(ofnode_valid(node));
+	str = ofnode_read_string(node, propname);
+	ut_assert(str && !strcmp(str, propval));
+
+	/* Find the rest of the matching nodes */
+	while (true) {
+		node = ofnode_by_prop_value(node, propname, propval,
+					    sizeof(propval));
+		if (!ofnode_valid(node))
+			break;
+		str = ofnode_read_string(node, propname);
+		ut_assert(str && !strcmp(str, propval));
+	}
+
+	return 0;
+}
+DM_TEST(dm_test_ofnode_by_prop_value, DM_TESTF_SCAN_FDT);