diff mbox series

firmware: Convert to using %pOFn instead of device_node.name

Message ID 20180828015252.28511-17-robh@kernel.org
State Accepted
Commit 75afbfc1156c8f7de5717a8d278a4da0d98a8532
Headers show
Series firmware: Convert to using %pOFn instead of device_node.name | expand

Commit Message

Rob Herring Aug. 28, 2018, 1:52 a.m. UTC
In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.

Signed-off-by: Rob Herring <robh@kernel.org>

---
 drivers/firmware/scpi_pm_domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Rob Herring Sept. 28, 2018, 9:47 p.m. UTC | #1
On Mon, Aug 27, 2018 at 8:53 PM Rob Herring <robh@kernel.org> wrote:
>

> In preparation to remove the node name pointer from struct device_node,

> convert printf users to use the %pOFn format specifier.

>

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  drivers/firmware/scpi_pm_domain.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Sudeep, looks like I missed Cc'ing you (or anyone) on this. Can you
please ack or apply this.

>

> diff --git a/drivers/firmware/scpi_pm_domain.c b/drivers/firmware/scpi_pm_domain.c

> index f395dec27113..390aa13391e4 100644

> --- a/drivers/firmware/scpi_pm_domain.c

> +++ b/drivers/firmware/scpi_pm_domain.c

> @@ -121,7 +121,7 @@ static int scpi_pm_domain_probe(struct platform_device *pdev)

>

>                 scpi_pd->domain = i;

>                 scpi_pd->ops = scpi_ops;

> -               sprintf(scpi_pd->name, "%s.%d", np->name, i);

> +               sprintf(scpi_pd->name, "%pOFn.%d", np, i);

>                 scpi_pd->genpd.name = scpi_pd->name;

>                 scpi_pd->genpd.power_off = scpi_pd_power_off;

>                 scpi_pd->genpd.power_on = scpi_pd_power_on;

> --

> 2.17.1

>
Sudeep Holla Oct. 1, 2018, 9:09 a.m. UTC | #2
On Fri, Sep 28, 2018 at 04:47:41PM -0500, Rob Herring wrote:
> On Mon, Aug 27, 2018 at 8:53 PM Rob Herring <robh@kernel.org> wrote:

> >

> > In preparation to remove the node name pointer from struct device_node,

> > convert printf users to use the %pOFn format specifier.

> >

> > Signed-off-by: Rob Herring <robh@kernel.org>

> > ---

> >  drivers/firmware/scpi_pm_domain.c | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

>

> Sudeep, looks like I missed Cc'ing you (or anyone) on this. Can you

> please ack or apply this.

>

I prefer you to take it via your tree as that may be easier.

Acked-by: Sudeep Holla <sudeep.holla@arm.com>


--
Regards,
Sudeep
diff mbox series

Patch

diff --git a/drivers/firmware/scpi_pm_domain.c b/drivers/firmware/scpi_pm_domain.c
index f395dec27113..390aa13391e4 100644
--- a/drivers/firmware/scpi_pm_domain.c
+++ b/drivers/firmware/scpi_pm_domain.c
@@ -121,7 +121,7 @@  static int scpi_pm_domain_probe(struct platform_device *pdev)
 
 		scpi_pd->domain = i;
 		scpi_pd->ops = scpi_ops;
-		sprintf(scpi_pd->name, "%s.%d", np->name, i);
+		sprintf(scpi_pd->name, "%pOFn.%d", np, i);
 		scpi_pd->genpd.name = scpi_pd->name;
 		scpi_pd->genpd.power_off = scpi_pd_power_off;
 		scpi_pd->genpd.power_on = scpi_pd_power_on;