[oe] python-protobuf: disable clean

Message ID 20180831144216.5212-1-ross.burton@intel.com
State New
Headers show
Series
  • [oe] python-protobuf: disable clean
Related show

Commit Message

Ross Burton Aug. 31, 2018, 2:42 p.m.
The distutils class does a 'setup.py clean' but this breaks the protobuf build:

| Can't find required file: ../src/google/protobuf/descriptor.proto
| Generating google/protobuf/descriptor_pb2.py...
| ERROR: python3 setup.py build_ext execution failed.

Disable the clean to work around this.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta-python/recipes-devtools/python/python-protobuf.inc | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.11.0

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Martin Jansa Aug. 31, 2018, 2:45 p.m. | #1
Isn't this already covered by:
http://git.openembedded.org/meta-openembedded/commit/?id=19aeaf028f6819e5fa705593d4bcdbf0b98143e0
http://git.openembedded.org/meta-openembedded/commit/?id=e65b1c4ebbbf2174125e7c659b908dd0f46c4509
https://patchwork.openembedded.org/patch/154300/
?

On Fri, Aug 31, 2018 at 4:42 PM Ross Burton <ross.burton@intel.com> wrote:

> The distutils class does a 'setup.py clean' but this breaks the protobuf

> build:

>

> | Can't find required file: ../src/google/protobuf/descriptor.proto

> | Generating google/protobuf/descriptor_pb2.py...

> | ERROR: python3 setup.py build_ext execution failed.

>

> Disable the clean to work around this.

>

> Signed-off-by: Ross Burton <ross.burton@intel.com>

> ---

>  meta-python/recipes-devtools/python/python-protobuf.inc | 2 ++

>  1 file changed, 2 insertions(+)

>

> diff --git a/meta-python/recipes-devtools/python/python-protobuf.inc

> b/meta-python/recipes-devtools/python/python-protobuf.inc

> index 6a0568ae62..421775d394 100644

> --- a/meta-python/recipes-devtools/python/python-protobuf.inc

> +++ b/meta-python/recipes-devtools/python/python-protobuf.inc

> @@ -25,3 +25,5 @@ RDEPENDS_${PN} += " \

>

>  # For usage in other recipies when compiling protobuf files (e.g. by

> grpcio-tools)

>  BBCLASSEXTEND = "native"

> +

> +CLEANBROKEN = "1"

> --

> 2.11.0

>

> --

> _______________________________________________

> Openembedded-devel mailing list

> Openembedded-devel@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

>

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Ross Burton Aug. 31, 2018, 2:54 p.m. | #2
Erm, yeah, that would be a rebase gone bad.

Thanks for spotting ;)
Ross

On 31 August 2018 at 15:45, Martin Jansa <martin.jansa@gmail.com> wrote:
> Isn't this already covered by:

> http://git.openembedded.org/meta-openembedded/commit/?id=19aeaf028f6819e5fa705593d4bcdbf0b98143e0

> http://git.openembedded.org/meta-openembedded/commit/?id=e65b1c4ebbbf2174125e7c659b908dd0f46c4509

> https://patchwork.openembedded.org/patch/154300/

> ?

>

> On Fri, Aug 31, 2018 at 4:42 PM Ross Burton <ross.burton@intel.com> wrote:

>>

>> The distutils class does a 'setup.py clean' but this breaks the protobuf

>> build:

>>

>> | Can't find required file: ../src/google/protobuf/descriptor.proto

>> | Generating google/protobuf/descriptor_pb2.py...

>> | ERROR: python3 setup.py build_ext execution failed.

>>

>> Disable the clean to work around this.

>>

>> Signed-off-by: Ross Burton <ross.burton@intel.com>

>> ---

>>  meta-python/recipes-devtools/python/python-protobuf.inc | 2 ++

>>  1 file changed, 2 insertions(+)

>>

>> diff --git a/meta-python/recipes-devtools/python/python-protobuf.inc

>> b/meta-python/recipes-devtools/python/python-protobuf.inc

>> index 6a0568ae62..421775d394 100644

>> --- a/meta-python/recipes-devtools/python/python-protobuf.inc

>> +++ b/meta-python/recipes-devtools/python/python-protobuf.inc

>> @@ -25,3 +25,5 @@ RDEPENDS_${PN} += " \

>>

>>  # For usage in other recipies when compiling protobuf files (e.g. by

>> grpcio-tools)

>>  BBCLASSEXTEND = "native"

>> +

>> +CLEANBROKEN = "1"

>> --

>> 2.11.0

>>

>> --

>> _______________________________________________

>> Openembedded-devel mailing list

>> Openembedded-devel@lists.openembedded.org

>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-python/recipes-devtools/python/python-protobuf.inc b/meta-python/recipes-devtools/python/python-protobuf.inc
index 6a0568ae62..421775d394 100644
--- a/meta-python/recipes-devtools/python/python-protobuf.inc
+++ b/meta-python/recipes-devtools/python/python-protobuf.inc
@@ -25,3 +25,5 @@  RDEPENDS_${PN} += " \
 
 # For usage in other recipies when compiling protobuf files (e.g. by grpcio-tools)
 BBCLASSEXTEND = "native"
+
+CLEANBROKEN = "1"