diff mbox series

[2/3] arm64: dts: meson-axg: s400: add dmic codec

Message ID 20180831150218.8307-3-jbrunet@baylibre.com
State Accepted
Commit 63d1e75742fecf40a54963fcb8b089e78395cae4
Headers show
Series arm64: dts: meson-axg: add pdm support | expand

Commit Message

Jerome Brunet Aug. 31, 2018, 3:02 p.m. UTC
There are 7 digital mics on the MIC daughter board attached
to the s400 board, so add the digital microphone codec to
its DTS

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

---
 arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
2.17.1

Comments

Fabio Estevam Sept. 1, 2018, 9:24 p.m. UTC | #1
Hi Jerome,

On Fri, Aug 31, 2018 at 12:02 PM, Jerome Brunet <jbrunet@baylibre.com> wrote:
> There are 7 digital mics on the MIC daughter board attached

> to the s400 board, so add the digital microphone codec to

> its DTS

>

> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

> ---

>  arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 9 +++++++++

>  1 file changed, 9 insertions(+)

>

> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts

> index ff64c429d432..f3e16cbbc61e 100644

> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts

> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts

> @@ -86,6 +86,15 @@

>                 sound-name-prefix = "DIT";

>         };

>

> +       dmics: audio-codec@3 {


You pass @3 without a corresponding reg = <3>, which causes dtc
warnings with W=1.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
index ff64c429d432..f3e16cbbc61e 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
@@ -86,6 +86,15 @@ 
 		sound-name-prefix = "DIT";
 	};
 
+	dmics: audio-codec@3 {
+		#sound-dai-cells = <0>;
+		compatible = "dmic-codec";
+		num-channels = <7>;
+		wakeup-delay-ms = <50>;
+		status = "okay";
+		sound-name-prefix = "MIC";
+	};
+
 	emmc_pwrseq: emmc-pwrseq {
 		compatible = "mmc-pwrseq-emmc";
 		reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>;