[02/12] dmaengine: bcm2835: remove dma_slave_config direction usage

Message ID 20180911083536.16482-3-vkoul@kernel.org
State New
Headers show
Series
  • dmaengine: remove usage of dma_slave_config direction
Related show

Commit Message

Vinod Koul Sept. 11, 2018, 8:35 a.m.
dma_slave_config direction was marked as deprecated quite some
time back, remove the usage from this driver so that the field
can be removed

Signed-off-by: Vinod Koul <vkoul@kernel.org>

---
CC: Ray Jui <rjui@broadcom.com>
CC: Scott Branden <sbranden@broadcom.com>

 drivers/dma/bcm2835-dma.c | 8 --------
 1 file changed, 8 deletions(-)

-- 
2.14.4

Comments

Scott Branden Sept. 11, 2018, 9:11 p.m. | #1
On 18-09-11 01:35 AM, Vinod Koul wrote:
> dma_slave_config direction was marked as deprecated quite some

> time back, remove the usage from this driver so that the field

> can be removed

>

> Signed-off-by: Vinod Koul <vkoul@kernel.org>

Acked-by: Scott Branden <scott.branden@broadcom.com>

> ---

> CC: Ray Jui <rjui@broadcom.com>

> CC: Scott Branden <sbranden@broadcom.com>

>

>   drivers/dma/bcm2835-dma.c | 8 --------

>   1 file changed, 8 deletions(-)

>

> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c

> index 847f84a41a69..cad55ab80d41 100644

> --- a/drivers/dma/bcm2835-dma.c

> +++ b/drivers/dma/bcm2835-dma.c

> @@ -778,14 +778,6 @@ static int bcm2835_dma_slave_config(struct dma_chan *chan,

>   {

>   	struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);

>   

> -	if ((cfg->direction == DMA_DEV_TO_MEM &&

> -	     cfg->src_addr_width != DMA_SLAVE_BUSWIDTH_4_BYTES) ||

> -	    (cfg->direction == DMA_MEM_TO_DEV &&

> -	     cfg->dst_addr_width != DMA_SLAVE_BUSWIDTH_4_BYTES) ||

> -	    !is_slave_direction(cfg->direction)) {

> -		return -EINVAL;

> -	}

> -

>   	c->cfg = *cfg;

>   

>   	return 0;

Patch

diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 847f84a41a69..cad55ab80d41 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -778,14 +778,6 @@  static int bcm2835_dma_slave_config(struct dma_chan *chan,
 {
 	struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);
 
-	if ((cfg->direction == DMA_DEV_TO_MEM &&
-	     cfg->src_addr_width != DMA_SLAVE_BUSWIDTH_4_BYTES) ||
-	    (cfg->direction == DMA_MEM_TO_DEV &&
-	     cfg->dst_addr_width != DMA_SLAVE_BUSWIDTH_4_BYTES) ||
-	    !is_slave_direction(cfg->direction)) {
-		return -EINVAL;
-	}
-
 	c->cfg = *cfg;
 
 	return 0;