[07/12] dmaengine: hsu: remove dma_slave_config direction usage

Message ID 20180911083536.16482-8-vkoul@kernel.org
State New
Headers show
Series
  • dmaengine: remove usage of dma_slave_config direction
Related show

Commit Message

Vinod Koul Sept. 11, 2018, 8:35 a.m.
dma_slave_config direction was marked as deprecated quite some
time back, remove the usage from this driver so that the field
can be removed

Signed-off-by: Vinod Koul <vkoul@kernel.org>

---
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

 drivers/dma/hsu/hsu.c | 4 ----
 1 file changed, 4 deletions(-)

-- 
2.14.4

Comments

Andy Shevchenko Sept. 21, 2018, 5:03 p.m. | #1
On Tue, Sep 11, 2018 at 02:05:31PM +0530, Vinod Koul wrote:
> dma_slave_config direction was marked as deprecated quite some

> time back, remove the usage from this driver so that the field

> can be removed

> 


Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


> Signed-off-by: Vinod Koul <vkoul@kernel.org>

> ---

> CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> 

>  drivers/dma/hsu/hsu.c | 4 ----

>  1 file changed, 4 deletions(-)

> 

> diff --git a/drivers/dma/hsu/hsu.c b/drivers/dma/hsu/hsu.c

> index 202ffa9f7611..e06f20272fd7 100644

> --- a/drivers/dma/hsu/hsu.c

> +++ b/drivers/dma/hsu/hsu.c

> @@ -348,10 +348,6 @@ static int hsu_dma_slave_config(struct dma_chan *chan,

>  {

>  	struct hsu_dma_chan *hsuc = to_hsu_dma_chan(chan);

>  

> -	/* Check if chan will be configured for slave transfers */

> -	if (!is_slave_direction(config->direction))

> -		return -EINVAL;

> -

>  	memcpy(&hsuc->config, config, sizeof(hsuc->config));

>  

>  	return 0;

> -- 

> 2.14.4

> 


-- 
With Best Regards,
Andy Shevchenko

Patch

diff --git a/drivers/dma/hsu/hsu.c b/drivers/dma/hsu/hsu.c
index 202ffa9f7611..e06f20272fd7 100644
--- a/drivers/dma/hsu/hsu.c
+++ b/drivers/dma/hsu/hsu.c
@@ -348,10 +348,6 @@  static int hsu_dma_slave_config(struct dma_chan *chan,
 {
 	struct hsu_dma_chan *hsuc = to_hsu_dma_chan(chan);
 
-	/* Check if chan will be configured for slave transfers */
-	if (!is_slave_direction(config->direction))
-		return -EINVAL;
-
 	memcpy(&hsuc->config, config, sizeof(hsuc->config));
 
 	return 0;