diff mbox series

[v1,4/4] tests/guest-debug: fix scoping of failcount

Message ID 20180926112048.17778-5-alex.bennee@linaro.org
State Superseded
Headers show
Series fixes for kvm/arm64 guest debug | expand

Commit Message

Alex Bennée Sept. 26, 2018, 11:20 a.m. UTC 
You should declare you are using a global version of a variable before
you attempt to modify it in a function.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 tests/guest-debug/test-gdbstub.py | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

Comments

Peter Maydell Oct. 2, 2018, 9:59 a.m. UTC | #1 
On 26 September 2018 at 12:20, Alex Bennée <alex.bennee@linaro.org> wrote:
> You should declare you are using a global version of a variable before

> you attempt to modify it in a function.

>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  tests/guest-debug/test-gdbstub.py | 1 +

>  1 file changed, 1 insertion(+)

>

> diff --git a/tests/guest-debug/test-gdbstub.py b/tests/guest-debug/test-gdbstub.py

> index 474d2c5c65..7bfc95b187 100644

> --- a/tests/guest-debug/test-gdbstub.py

> +++ b/tests/guest-debug/test-gdbstub.py

> @@ -16,6 +16,7 @@ def report(cond, msg):

>          print ("PASS: %s" % (msg))

>      else:

>          print ("FAIL: %s" % (msg))

> +        global failcount

>          failcount += 1



Reviewed-by: Peter Maydell <peter.maydell@linaro.org>


Incidentally, if we ever get above 127 tests in this file,
the "exit(failcount)" at the bottom of the script will
not DTRT :-)

thanks
-- PMM
diff mbox series

Patch

diff --git a/tests/guest-debug/test-gdbstub.py b/tests/guest-debug/test-gdbstub.py
index 474d2c5c65..7bfc95b187 100644
--- a/tests/guest-debug/test-gdbstub.py
+++ b/tests/guest-debug/test-gdbstub.py
@@ -16,6 +16,7 @@  def report(cond, msg):
         print ("PASS: %s" % (msg))
     else:
         print ("FAIL: %s" % (msg))
+        global failcount
         failcount += 1