| Message ID | 1360912200-26377-6-git-send-email-vikas.sajjan@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi, On 02/15/2013 08:10 AM, Vikas Sajjan wrote: > Adds FIMD DT binding documentation both SoC and Board, with an example > > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org> > --- > .../devicetree/bindings/drm/exynos/fimd.txt | 37 ++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/drm/exynos/fimd.txt > > diff --git a/Documentation/devicetree/bindings/drm/exynos/fimd.txt b/Documentation/devicetree/bindings/drm/exynos/fimd.txt > new file mode 100644 > index 0000000..bec9d07 > --- /dev/null > +++ b/Documentation/devicetree/bindings/drm/exynos/fimd.txt > @@ -0,0 +1,37 @@ > +Device-Tree bindings for fimd driver > + > +FIMD stands for Fully Interactive Mobile Display, is the Display Controller for > +the Exynos series of SoCs which transfers the image data from a video buffer > +located in the system memory to an external LCD interface. > + > +Required properties: > +- compatible := value should be "samsung,exynos5-fimd" or "samsung,exynos4-fimd" What about older SoCs like S5Pv210 ? There is the FIMD IP block in those SoCs as well. There are also differences in the FIMD IP block across various SoC version, so either you need to list the quirks in the bindings or use an appropriate compatible properties if there are significant differences across FIMDs that make them not really compatible. > +- reg := physical base address of the fimd and length of memory mapped region > +- interrupt-parent := reference to the interrupt combiner node with phandle > +- interrupts := interrupt number from the combiner to the cpu These are actually 3 interrupts. Can you please document what they are and in what order should be listed in the interrupts property ? > +- pinctrl := property defining the pinctrl configurations with a phandle > +- pinctrl-names := name of the pinctrl > + > +Optional Properties: > +- samsung,power-domain := power domain property defined with a phandle > +- status := property defining the status of the node I don't think this standard property needs to be documented here. > + > +Example: > + > +SoC specific DT Entry: > + > + fimd@11c00000 { > + compatible = "samsung,exynos4-fimd"; > + interrupt-parent = <&combiner>; > + reg = <0x11c00000 0x20000>; > + interrupts = <11 1>, <11 0>, <11 2>; Why this order exactly ? Because currently the driver expects VSYNC interrupt specifier in the first entry and it won't work when you put any other interrupt specifier there ? The interrupts order really needs to be specified above, otherwise you need to look at the bindings implementation in the driver to figure out why it didn't work when you put the interrupt in different order... see confused and angry faces of developers ? ... :) If I'm not mistaken we have "Video Frame" (VSYNC), "I80 Interface" and "FIFO Level" interrupts here. > + }; Thanks,
diff --git a/Documentation/devicetree/bindings/drm/exynos/fimd.txt b/Documentation/devicetree/bindings/drm/exynos/fimd.txt new file mode 100644 index 0000000..bec9d07 --- /dev/null +++ b/Documentation/devicetree/bindings/drm/exynos/fimd.txt @@ -0,0 +1,37 @@ +Device-Tree bindings for fimd driver + +FIMD stands for Fully Interactive Mobile Display, is the Display Controller for +the Exynos series of SoCs which transfers the image data from a video buffer +located in the system memory to an external LCD interface. + +Required properties: +- compatible := value should be "samsung,exynos5-fimd" or "samsung,exynos4-fimd" +- reg := physical base address of the fimd and length of memory mapped region +- interrupt-parent := reference to the interrupt combiner node with phandle +- interrupts := interrupt number from the combiner to the cpu +- pinctrl := property defining the pinctrl configurations with a phandle +- pinctrl-names := name of the pinctrl + +Optional Properties: +- samsung,power-domain := power domain property defined with a phandle +- status := property defining the status of the node + +Example: + +SoC specific DT Entry: + + fimd@11c00000 { + compatible = "samsung,exynos4-fimd"; + interrupt-parent = <&combiner>; + reg = <0x11c00000 0x20000>; + interrupts = <11 1>, <11 0>, <11 2>; + }; + +Board specific DT Entry: + + fimd@11c00000 { + samsung,power-domain = <&pd_lcd0>; + pinctrl-0 = <&lcd_sync &lcd_clk &lcd_en &lcd0_data &pwm1_out>; + pinctrl-names = "default"; + status = "okay"; + };
Adds FIMD DT binding documentation both SoC and Board, with an example Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org> --- .../devicetree/bindings/drm/exynos/fimd.txt | 37 ++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/drm/exynos/fimd.txt