| Message ID | 20181011165123.32198-3-dmurphy@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Thu 2018-10-11 11:51:16, Dan Murphy wrote: > Remove support for the LM3697 LED device > from the ti-lmu. The LM3697 will be supported > via a stand alone LED driver. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> NAK. Pavel > index c885cf89b8ce..920f910be4e9 100644 > --- a/Documentation/devicetree/bindings/mfd/ti-lmu.txt > +++ b/Documentation/devicetree/bindings/mfd/ti-lmu.txt > @@ -9,7 +9,6 @@ TI LMU driver supports lighting devices below. > LM3632 Backlight and regulator > LM3633 Backlight, LED and fault monitor > LM3695 Backlight > - LM3697 Backlight and fault monitor > > Required properties: > - compatible: Should be one of: > @@ -18,11 +17,10 @@ Required properties: > "ti,lm3632" > "ti,lm3633" > "ti,lm3695" > - "ti,lm3697" > - reg: I2C slave address. > 0x11 for LM3632 > 0x29 for LM3631 > - 0x36 for LM3633, LM3697 > + 0x36 for LM3633 > 0x38 for LM3532 > 0x63 for LM3695 > > @@ -38,7 +36,6 @@ Optional nodes: > Required properties: > - compatible: Should be one of: > "ti,lm3633-fault-monitor" > - "ti,lm3697-fault-monitor" > - leds: LED properties for LM3633. Please refer to [2]. > - regulators: Regulator properties for LM3631 and LM3632. > Please refer to [3]. > @@ -220,24 +217,3 @@ lm3695@63 { > }; > }; > }; > - > -lm3697@36 { > - compatible = "ti,lm3697"; > - reg = <0x36>; > - > - enable-gpios = <&pioC 2 GPIO_ACTIVE_HIGH>; > - > - backlight { > - compatible = "ti,lm3697-backlight"; > - > - lcd { > - led-sources = <0 1 2>; > - ramp-up-msec = <200>; > - ramp-down-msec = <200>; > - }; > - }; > - > - fault-monitor { > - compatible = "ti,lm3697-fault-monitor"; > - }; > -}; -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On 10/11/2018 08:34 PM, Dan Murphy wrote: > Pavel > > On 10/11/2018 01:27 PM, Pavel Machek wrote: >> On Thu 2018-10-11 11:51:16, Dan Murphy wrote: >>> Remove support for the LM3697 LED device >>> from the ti-lmu. The LM3697 will be supported >>> via a stand alone LED driver. >>> >>> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> >> NAK. > > Thanks for the NAK. > > This NAK was NAK'd by other maintainer in the V2 RFC patchset > > https://lore.kernel.org/patchwork/patch/993171/ I confirm. LM3697 is a standalone device and not a cell of any MFD device. Waiting for DT maintainer's ack. Best regards, Jacek Anaszewski >>> index c885cf89b8ce..920f910be4e9 100644 >>> --- a/Documentation/devicetree/bindings/mfd/ti-lmu.txt >>> +++ b/Documentation/devicetree/bindings/mfd/ti-lmu.txt >>> @@ -9,7 +9,6 @@ TI LMU driver supports lighting devices below. >>> LM3632 Backlight and regulator >>> LM3633 Backlight, LED and fault monitor >>> LM3695 Backlight >>> - LM3697 Backlight and fault monitor >>> >>> Required properties: >>> - compatible: Should be one of: >>> @@ -18,11 +17,10 @@ Required properties: >>> "ti,lm3632" >>> "ti,lm3633" >>> "ti,lm3695" >>> - "ti,lm3697" >>> - reg: I2C slave address. >>> 0x11 for LM3632 >>> 0x29 for LM3631 >>> - 0x36 for LM3633, LM3697 >>> + 0x36 for LM3633 >>> 0x38 for LM3532 >>> 0x63 for LM3695 >>> >>> @@ -38,7 +36,6 @@ Optional nodes: >>> Required properties: >>> - compatible: Should be one of: >>> "ti,lm3633-fault-monitor" >>> - "ti,lm3697-fault-monitor" >>> - leds: LED properties for LM3633. Please refer to [2]. >>> - regulators: Regulator properties for LM3631 and LM3632. >>> Please refer to [3]. >>> @@ -220,24 +217,3 @@ lm3695@63 { >>> }; >>> }; >>> }; >>> - >>> -lm3697@36 { >>> - compatible = "ti,lm3697"; >>> - reg = <0x36>; >>> - >>> - enable-gpios = <&pioC 2 GPIO_ACTIVE_HIGH>; >>> - >>> - backlight { >>> - compatible = "ti,lm3697-backlight"; >>> - >>> - lcd { >>> - led-sources = <0 1 2>; >>> - ramp-up-msec = <200>; >>> - ramp-down-msec = <200>; >>> - }; >>> - }; >>> - >>> - fault-monitor { >>> - compatible = "ti,lm3697-fault-monitor"; >>> - }; >>> -}; >> > >
On Thu, 11 Oct 2018, Dan Murphy wrote: > Remove support for the LM3697 LED device > from the ti-lmu. The LM3697 will be supported > via a stand alone LED driver. What's with the odd 50 char line wrapping? > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > .../devicetree/bindings/mfd/ti-lmu.txt | 26 +------------------ > 1 file changed, 1 insertion(+), 25 deletions(-) For the code: For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
On 10/12/2018 08:03 PM, Pavel Machek wrote: > Hi! > >>>>>> Signed-off-by: Dan Murphy <dmurphy@ti.com> >>>>> >>>>> NAK. >>>> >>>> Thanks for the NAK. >>>> >>>> This NAK was NAK'd by other maintainer in the V2 RFC patchset >>>> >>>> https://lore.kernel.org/patchwork/patch/993171/ >>> >>> I confirm. LM3697 is a standalone device and not a cell of any >>> MFD device. >>> >>> Waiting for DT maintainer's ack. >> >> You all sort out what you want... I can't follow it all, and I'm not >> going to spend the time trying to figure out what is going on here. > > This is what I want: > >> As this is worded, changing the driver is a Linux problem and irrelevant >> to the binding. Now if you want to move documentation to a location that >> makes more sense, then fine. But structure patches that way and make it >> clear that from an binding ABI perspective, nothing is changing. > > ...but apparently I did not have enough authority to get it. > > (I'm ok with move, and it is possible that binding does need some > fixups besides the move; still it should be done as fixup not as a new > binding). There is a fundamental question - should the bindings be considered an ABI, even though there is no mainline "*.dts" implementation basing on these bindings? This patch fixes the issues of bindings in a way that would change the ABI, if only it existed. But it apparently doesn't exist in mainline. Unless a DT documentation itself constitutes an ABI. I'd like to have it clarified at this occasion, and that's why I kindly ask for DT maintainer's ack or NACK for this modification of bindings. For a reference we have a nice summary of the MFD driver and related bindings' flaws in [0] and [1]. [0] https://lkml.org/lkml/2018/9/7/774 [1] https://lkml.org/lkml/2018/9/11/984 -- Best regards, Jacek Anaszewski
On Fri 2018-10-19 07:58:12, Tony Lindgren wrote: > * Dan Murphy <dmurphy@ti.com> [181019 11:42]: > > On 10/18/2018 05:10 PM, Pavel Machek wrote: > > > > > > Now... this is what I've suggested before. If you don't agree, you may > > > want to contact Tony Lindgren, IIRC he works for TI, too, and might be > > > willing to help. > > > > I will ping Tony just to close the loop. I will be posting v4 today after making the changes. > > I was hoping to have some code review prior to posting v4 but have not received any comments so > > v4 will just be a patch rearrangement. > > I guess not much to ping here though as I know little about these > chips :) As long as Rob is happy with the binding changes I'll be > happy too. Well, question is more "how to make Rob happy". I see v4 is out, let me comment on that. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
diff --git a/Documentation/devicetree/bindings/mfd/ti-lmu.txt b/Documentation/devicetree/bindings/mfd/ti-lmu.txt index c885cf89b8ce..920f910be4e9 100644 --- a/Documentation/devicetree/bindings/mfd/ti-lmu.txt +++ b/Documentation/devicetree/bindings/mfd/ti-lmu.txt @@ -9,7 +9,6 @@ TI LMU driver supports lighting devices below. LM3632 Backlight and regulator LM3633 Backlight, LED and fault monitor LM3695 Backlight - LM3697 Backlight and fault monitor Required properties: - compatible: Should be one of: @@ -18,11 +17,10 @@ Required properties: "ti,lm3632" "ti,lm3633" "ti,lm3695" - "ti,lm3697" - reg: I2C slave address. 0x11 for LM3632 0x29 for LM3631 - 0x36 for LM3633, LM3697 + 0x36 for LM3633 0x38 for LM3532 0x63 for LM3695 @@ -38,7 +36,6 @@ Optional nodes: Required properties: - compatible: Should be one of: "ti,lm3633-fault-monitor" - "ti,lm3697-fault-monitor" - leds: LED properties for LM3633. Please refer to [2]. - regulators: Regulator properties for LM3631 and LM3632. Please refer to [3]. @@ -220,24 +217,3 @@ lm3695@63 { }; }; }; - -lm3697@36 { - compatible = "ti,lm3697"; - reg = <0x36>; - - enable-gpios = <&pioC 2 GPIO_ACTIVE_HIGH>; - - backlight { - compatible = "ti,lm3697-backlight"; - - lcd { - led-sources = <0 1 2>; - ramp-up-msec = <200>; - ramp-down-msec = <200>; - }; - }; - - fault-monitor { - compatible = "ti,lm3697-fault-monitor"; - }; -};
Remove support for the LM3697 LED device from the ti-lmu. The LM3697 will be supported via a stand alone LED driver. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- .../devicetree/bindings/mfd/ti-lmu.txt | 26 +------------------ 1 file changed, 1 insertion(+), 25 deletions(-) -- 2.19.0