| Message ID | 20181012195232.4024123-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 44eb385bc5f315c3707ffdaffd5cb9d3e78c1839 |
| Headers | show |
| Series | [net-next] octeontx2-af: remove unused cgx_fwi_link_change | expand |
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 12 Oct 2018 21:52:22 +0200 > The newly added driver causes a warning about a function that is > not used anywhere: > > drivers/net/ethernet/marvell/octeontx2/af/cgx.c:320:12: error: 'cgx_fwi_link_change' defined but not used [-Werror=unused-function] > > Remove it for now, until a user gets added. If we want to use this > function from another module, we also need a declaration in a header > file, which is currently missing, so it would have to change anyway. > > Fixes: 1463f382f58d ("octeontx2-af: Add support for CGX link management") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied.
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c index 2cf8e402c31e..5328ecc8cea2 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c @@ -58,9 +58,6 @@ struct cgx { static LIST_HEAD(cgx_list); -/* CGX PHY management internal APIs */ -static int cgx_fwi_link_change(struct cgx *cgx, int lmac_id, bool en); - /* Supported devices */ static const struct pci_device_id cgx_id_table[] = { { PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_OCTEONTX2_CGX) }, @@ -317,20 +314,6 @@ int cgx_lmac_evh_register(struct cgx_event_cb *cb, void *cgxd, int lmac_id) } EXPORT_SYMBOL(cgx_lmac_evh_register); -static int cgx_fwi_link_change(struct cgx *cgx, int lmac_id, bool enable) -{ - u64 req = 0; - u64 resp; - - if (enable) - req = FIELD_SET(CMDREG_ID, CGX_CMD_LINK_BRING_UP, req); - else - req = FIELD_SET(CMDREG_ID, CGX_CMD_LINK_BRING_DOWN, req); - - return cgx_fwi_cmd_generic(req, &resp, cgx, lmac_id); -} -EXPORT_SYMBOL(cgx_fwi_link_change); - static inline int cgx_fwi_read_version(u64 *resp, struct cgx *cgx) { u64 req = 0;
The newly added driver causes a warning about a function that is not used anywhere: drivers/net/ethernet/marvell/octeontx2/af/cgx.c:320:12: error: 'cgx_fwi_link_change' defined but not used [-Werror=unused-function] Remove it for now, until a user gets added. If we want to use this function from another module, we also need a declaration in a header file, which is currently missing, so it would have to change anyway. Fixes: 1463f382f58d ("octeontx2-af: Add support for CGX link management") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 17 ----------------- 1 file changed, 17 deletions(-) -- 2.18.0