diff mbox series

distro: Imply USB_STORAGE when USB is available

Message ID 20181018073920.16632-1-agraf@suse.de
State Accepted
Commit 4aa7492683f2d4a26d456d8734d8e59d6bd52e0d
Headers show
Series distro: Imply USB_STORAGE when USB is available | expand

Commit Message

Alexander Graf Oct. 18, 2018, 7:39 a.m. UTC
When you support distro boot and you support USB, you usually want to
also support booting from USB storage.

Reflect that in the Kconfig, so that we don't have to explicitly add
USB storage support to every defconfig individually.

Reported-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini Nov. 20, 2018, 2:55 p.m. UTC | #1
On Thu, Oct 18, 2018 at 09:39:20AM +0200, Alexander Graf wrote:

> When you support distro boot and you support USB, you usually want to

> also support booting from USB storage.

> 

> Reflect that in the Kconfig, so that we don't have to explicitly add

> USB storage support to every defconfig individually.

> 

> Reported-by: AKASHI Takahiro <takahiro.akashi@linaro.org>

> Signed-off-by: Alexander Graf <agraf@suse.de>


NAK:
drivers/usb/Kconfig:1:error: recursive dependency detected!
drivers/usb/Kconfig:1:  symbol USB is selected by DISTRO_DEFAULTS
Kconfig:89:     symbol DISTRO_DEFAULTS depends on USB
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"

Under sandbox_config

-- 
Tom
diff mbox series

Patch

diff --git a/Kconfig b/Kconfig
index 1aadf5dd2d..8d515fe18c 100644
--- a/Kconfig
+++ b/Kconfig
@@ -86,6 +86,7 @@  config DISTRO_DEFAULTS
 	select SUPPORT_RAW_INITRD
 	select SYS_LONGHELP
 	imply CMD_MII if NET
+	imply USB_STORAGE if USB
 	imply USE_BOOTCOMMAND
 	help
 	  Select this to enable various options and commands which are suitable