From patchwork Mon Oct 29 03:32:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ming Huang X-Patchwork-Id: 149615 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3597860ljp; Sun, 28 Oct 2018 20:33:01 -0700 (PDT) X-Google-Smtp-Source: AJdET5eKgXrtkYop10lN/Mzpr3LVjrlloQcU2pg6DKEJhQ/H5+xKb4WoYp2OJBPonic9/xPwtuy1 X-Received: by 2002:a17:902:650f:: with SMTP id b15-v6mr12635408plk.2.1540783980939; Sun, 28 Oct 2018 20:33:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540783980; cv=none; d=google.com; s=arc-20160816; b=vdXFwCwNcbr6TVF3cSdigkLXCXA6IMrF71Y+SFrCYFoRAyinnulolznGMuKv/WQ7Md vIO6x1AAYXVSTNzlJOfA6ouID+CmTSPiWYDHeDoPx8bKD825q2ABTU6Q6wsf2vJ6Pztg Wm88Vi8/Zn9bAWhWLuGtKYZ2DHdGqVACkNYnGNjHUzewS1JpysC1TMAWemcr+Ig7RDQu 0Y76HaTdXtx1P0tEl1x4XwNCdqg3BpJolqIyF4R5Kiz4zA+Rp/G0tgNV5MfXg2EFyyd+ LmZscGE41hFKmULjwWFYH+opNWjMcTnHFtaoMJTeVl6uWiqJXtsAo7aSeQwqjiwS6MU1 2cUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=M8PVoeArG4aDrqVh+imEcm5ckWbIFsv55kRQeyOqTLM=; b=Bd+kaznBZVkRuXsWhLmNdGR88OCCPUy2MhBwSaH6n4BBvDexxasGajow/9UzMwipyc wh+AzOzcI6s3oOk+1NfrWjEuN1+6Vw1Hz4kmP56pJ2jX9Z7gOB6pvOsdOm5rN2VtI7N5 L5iFU9lkE42f5FcHTQlt28XLM0scDQfCkHzff4z3SDV+gxCMDntG8y2IDlh5scsXJ3zg rrQLnaso+KAhUvy9Syc4Ah0yafxlw6BTzXxgbALwEkDGjGYs0EMTcEt24/d7yOXcLr+4 PgZUK+oX/e3d9zSarr9DVBrPizGqTvnkZutfeKxlkd2RpJ5GpCsZjQwJnHswS+PuKn6g AaGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=FZzqOzTC; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id q2-v6si19214055plh.63.2018.10.28.20.33.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Oct 2018 20:33:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=FZzqOzTC; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 4C5A821180F34; Sun, 28 Oct 2018 20:33:00 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::643; helo=mail-pl1-x643.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9F25521167459 for ; Sun, 28 Oct 2018 20:32:57 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id p5-v6so3103281plq.8 for ; Sun, 28 Oct 2018 20:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cgt/ICV9N58989bE5liVWnjWOB0Hx40D7bm/AFrBkiE=; b=FZzqOzTCF7nsg+ae8RzM8KI3aZ10+wBRWTOOyeUVl7P8qPgcLPEvUphmSk9YBF+qmu REELU9UrqZz7qc2zCejPwAxp9VRPoCP6ZsL3iFcURVB6obpe3nMqldnenOn91HusM99A ODorGaKROt7HoRG7VcKitVSgluPO2WHnroZrc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cgt/ICV9N58989bE5liVWnjWOB0Hx40D7bm/AFrBkiE=; b=lEgmJMNz+n3fqxifWjsXi8ZNbgn90qoh2emoMa8aSrVxv3Ht0AHdikibVAy/YOD29e jXksA1egOhvcQ9Lyhrjlpcyk6C9tyW4f4juRSlBaGzbu8yJeQdM1Bmjy/j3kqcJKJix/ HbcMBTGL0UrjdaGW7a+1buOxZE0ibKmaNIpePMvFJcom1Qg9B0XzZNbt46r58SfnGSmK qF+kUugV/UXfa+tPiLKed/ZR1Tgttjev2sgbCKexLnxA33KJZMFob8o3qYQhT9pbqiCn Y++D0c8yXZ21L0YPrjOclJTSRXcPRzwlRQqbRcUtmgKFLzAbmuSoGAplHOC0Pk3PS9ME 96Mw== X-Gm-Message-State: AGRZ1gLn8+hrunfsPhNe9OOVmed5YmBjJAahdIgM6zfk7GAeD5VHEJoi 12/slWWYVw9u72h21bSl24vPgw== X-Received: by 2002:a17:902:b943:: with SMTP id h3-v6mr3235301pls.124.1540783977322; Sun, 28 Oct 2018 20:32:57 -0700 (PDT) Received: from localhost.localdomain ([120.31.149.194]) by smtp.gmail.com with ESMTPSA id j5-v6sm22318872pgm.79.2018.10.28.20.32.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 28 Oct 2018 20:32:56 -0700 (PDT) From: Ming Huang To: leif.lindholm@linaro.org, linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org Date: Mon, 29 Oct 2018 11:32:37 +0800 Message-Id: <20181029033249.45363-1-ming.huang@linaro.org> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-platforms v1 00/12] Fix D06 SBSA/SBBR issue and improve X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: huangming23@huawei.com, xinliang.liu@linaro.org, john.garry@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, zhangfeng56@huawei.com, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The major features of this patchset include: 1. Modify acpi table for ACS test; 2. Enable secure boot for SBBR-SCT; 3. Other change for ACS test; For this SCT issue: RT.SetVariable - Create one Time Base Auth Variable, the expect return status should be EFI_SUCCESS – FAILURE The resule of fail is effected by the edk2 commit(67943427). If Modify Variable.c as below, this case will pass. continue. Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git branch: d06-acs-platforms Ming Huang (12): Silicon/Hisilicon/D06: Add watchdog to GTDT Silicon/Hisilicon/D06: Drop _CID for fwts issue Silicon/Hisilicon/D06: Fix fwts issue in Dbg2 Silicon/Hisilicon/D06: Fix fwts issue in FADT Hisilicon/D06: Move some functions to OemMiscLib Silicon/Hisilicon: Modify for SBBR fwts SetTime_Func test case Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe Hisilicon/D06: Fix SBBR-SCT AuthVar issue Silicon/Hisilicon/D06: Reserve ECAM resource in DSDT Silicon/Hisilicon/D06: Modify GTDT timer flag Hisilicon/D06: Modify Gic base Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot Silicon/Hisilicon/HisiPkg.dec | 1 + Silicon/Hisilicon/Hisilicon.dsc.inc | 16 ++ Platform/Hisilicon/D03/D03.dsc | 5 + Platform/Hisilicon/D05/D05.dsc | 5 + Platform/Hisilicon/D06/D06.dsc | 9 +- .../Drivers/FlashFvbDxe/FlashFvbDxe.inf | 2 + .../M41T83RealTimeClockLib.inf | 3 +- .../Hi1620/Hi1620AcpiTables/Hi1620Platform.h | 2 +- .../Hisilicon/Include/Library/OemMiscLib.h | 9 + .../M41T83RealTimeClock.h | 8 +- .../D06/Library/OemMiscLibD06/OemMiscLibD06.c | 82 ++++++ .../Drivers/FlashFvbDxe/FlashFvbDxe.c | 14 +- .../M41T83RealTimeClockLib.c | 263 ++++++++++++------ .../Hi1620/Hi1620AcpiTables/Dsdt/Com.asl | 1 - .../Hi1620AcpiTables/Dsdt/Hi1620Mbig.asl | 48 ---- .../Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 36 ++- .../Hi1620/Hi1620AcpiTables/Fadt.aslc | 2 +- .../Hi1620/Hi1620AcpiTables/Gtdt.aslc | 35 +-- .../Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc | 4 +- .../Hi1620/Hi1620AcpiTables/Hi1620Iort.asl | 18 +- .../Hi1620/Hi1620AcpiTables/Hi1620Srat.aslc | 194 ++++++------- .../Hi1620/Hi1620AcpiTables/MadtHi1620.aslc | 2 +- 22 files changed, 475 insertions(+), 284 deletions(-) --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c @@ -3188,7 +3188,7 @@ VariableServiceSetVariable ( // Maybe it's the delete operation of common authenticated variable at // user physical presence. // if (DataSize != AUTHINFO_SIZE) { - return EFI_UNSUPPORTED; + return EFI_SECURITY_VIOLATION; I supect ACS SCT compatible with UEFI 2.7 spec. We will analyze this issue