diff mbox

[1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

Message ID 1361177589-23953-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat Feb. 18, 2013, 8:53 a.m. UTC
Silences the following sparse warning:
drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
symbol 'dw_mci_exynos_probe' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/mmc/host/dw_mmc-exynos.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Jaehoon Chung Feb. 18, 2013, 9:41 a.m. UTC | #1
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

On 02/18/2013 05:53 PM, Sachin Kamat wrote:
> Silences the following sparse warning:
> drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
> symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/dw_mmc-exynos.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 72fd0f2..5a09c77 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
>  
> -int dw_mci_exynos_probe(struct platform_device *pdev)
> +static int dw_mci_exynos_probe(struct platform_device *pdev)
>  {
>  	const struct dw_mci_drv_data *drv_data;
>  	const struct of_device_id *match;
>
Seungwon Jeon Feb. 18, 2013, 10:51 a.m. UTC | #2
Hi Sachin,

You're right.
'dw_mci_exynos_probe' is only used here.

Acked-by: Seungwon Jeon <tgih.jun@samsung.com>

On Monday, February 18, 2013, Jaehoon Chung wrote:
> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
> 
> On 02/18/2013 05:53 PM, Sachin Kamat wrote:
> > Silences the following sparse warning:
> > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
> > symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> >  drivers/mmc/host/dw_mmc-exynos.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> > index 72fd0f2..5a09c77 100644
> > --- a/drivers/mmc/host/dw_mmc-exynos.c
> > +++ b/drivers/mmc/host/dw_mmc-exynos.c
> > @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
> >  };
> >  MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
> >
> > -int dw_mci_exynos_probe(struct platform_device *pdev)
> > +static int dw_mci_exynos_probe(struct platform_device *pdev)
> >  {
> >  	const struct dw_mci_drv_data *drv_data;
> >  	const struct of_device_id *match;
> >
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sachin Kamat March 4, 2013, 4:36 a.m. UTC | #3
Hi Chris,

On 18 February 2013 16:21, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> Hi Sachin,
>
> You're right.
> 'dw_mci_exynos_probe' is only used here.
>
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
>
> On Monday, February 18, 2013, Jaehoon Chung wrote:
>> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> On 02/18/2013 05:53 PM, Sachin Kamat wrote:
>> > Silences the following sparse warning:
>> > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
>> > symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
>> >
>> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Can you please review this series?
Chris Ball March 12, 2013, 1:03 p.m. UTC | #4
Hi,

On Mon, Feb 18 2013, Sachin Kamat wrote:
> Silences the following sparse warning:
> drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
> symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/dw_mmc-exynos.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 72fd0f2..5a09c77 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
>  
> -int dw_mci_exynos_probe(struct platform_device *pdev)
> +static int dw_mci_exynos_probe(struct platform_device *pdev)
>  {
>  	const struct dw_mci_drv_data *drv_data;
>  	const struct of_device_id *match;

Thanks, pushed to mmc-next for 3.10.

- Chris.
diff mbox

Patch

diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 72fd0f2..5a09c77 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -215,7 +215,7 @@  static const struct of_device_id dw_mci_exynos_match[] = {
 };
 MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
 
-int dw_mci_exynos_probe(struct platform_device *pdev)
+static int dw_mci_exynos_probe(struct platform_device *pdev)
 {
 	const struct dw_mci_drv_data *drv_data;
 	const struct of_device_id *match;