| Message ID | 20181101101658.31442-1-julien.grall@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [Xen-devel] xen/grant_table: Remove stall comment on top of map_grant_ref | expand |
On 01/11/2018 10:16, Julien Grall wrote: > Remove the 2 part comment on top of map_grant_ref: > - The first part mention the return value which has been void since > 2006! > - The second part mention a local variable 'addr' which does not > exist anymore. > > Signed-off-by: Julien Grall <julien.grall@arm.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
On 11/01/2018 10:16 AM, Julien Grall wrote: > Remove the 2 part comment on top of map_grant_ref: > - The first part mention the return value which has been void since > 2006! > - The second part mention a local variable 'addr' which does not > exist anymore. > > Signed-off-by: Julien Grall <julien.grall@arm.com> Nit: s/stall/stale/; in title -George
Hi George, On 01/11/2018 11:03, George Dunlap wrote: > On 11/01/2018 10:16 AM, Julien Grall wrote: >> Remove the 2 part comment on top of map_grant_ref: >> - The first part mention the return value which has been void since >> 2006! >> - The second part mention a local variable 'addr' which does not >> exist anymore. >> >> Signed-off-by: Julien Grall <julien.grall@arm.com> > > Nit: s/stall/stale/; in title I will fix this on commit. Cheers, > > -George >
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index 878e668bf5..0b5894a070 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -890,13 +890,6 @@ static unsigned int mapkind( return kind; } -/* - * Returns 0 if TLB flush / invalidate required by caller. - * va will indicate the address to be invalidated. - * - * addr is _either_ a host virtual address, or the address of the pte to - * update, as indicated by the GNTMAP_contains_pte flag. - */ static void map_grant_ref( struct gnttab_map_grant_ref *op)
Remove the 2 part comment on top of map_grant_ref: - The first part mention the return value which has been void since 2006! - The second part mention a local variable 'addr' which does not exist anymore. Signed-off-by: Julien Grall <julien.grall@arm.com> --- xen/common/grant_table.c | 7 ------- 1 file changed, 7 deletions(-)