| Message ID | 20181102154740.2011289-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | a3ecf48248a393438e77e569a0047e968e0ec6c6 |
| Headers | show |
| Series | scsi: myrs: only build on little-endian platforms | expand |
On 11/2/18 4:47 PM, Arnd Bergmann wrote: > Reading throught the new driver, I noticed that this cannot work on > big-endian CPUs, and the old DAC960 had exactly the same behavior. > > To document this for the future, add a Kconfig dependency that prevents it > from being included in big-endian kernels. Since the hardware is really > old and we never had a working driver on it for big-endian platforms, > it's unlikely to make a difference to users. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/scsi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index f07444d30b21..640cd1b31a18 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -578,6 +578,7 @@ config SCSI_MYRB > config SCSI_MYRS > tristate "Mylex DAC960/DAC1100 PCI RAID Controller (SCSI Interface)" > depends on PCI > + depends on !CPU_BIG_ENDIAN || COMPILE_TEST > select RAID_ATTRS > help > This driver adds support for the Mylex DAC960, AcceleRAID, and > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
Arnd, > Reading throught the new driver, I noticed that this cannot work on > big-endian CPUs, and the old DAC960 had exactly the same behavior. > > To document this for the future, add a Kconfig dependency that prevents it > from being included in big-endian kernels. Since the hardware is really > old and we never had a working driver on it for big-endian platforms, > it's unlikely to make a difference to users. Applied to 4.20/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index f07444d30b21..640cd1b31a18 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -578,6 +578,7 @@ config SCSI_MYRB config SCSI_MYRS tristate "Mylex DAC960/DAC1100 PCI RAID Controller (SCSI Interface)" depends on PCI + depends on !CPU_BIG_ENDIAN || COMPILE_TEST select RAID_ATTRS help This driver adds support for the Mylex DAC960, AcceleRAID, and
Reading throught the new driver, I noticed that this cannot work on big-endian CPUs, and the old DAC960 had exactly the same behavior. To document this for the future, add a Kconfig dependency that prevents it from being included in big-endian kernels. Since the hardware is really old and we never had a working driver on it for big-endian platforms, it's unlikely to make a difference to users. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/scsi/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.18.0