| Message ID | 20181108125256.30986-1-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Commit | a7ce790a029bd94eb320d8c69f38900f5233997e |
| Headers | show |
| Series | tcg/tcg-op.h: Add multiple include guard | expand |
On Thu, Nov 8, 2018 at 4:53 PM Peter Maydell <peter.maydell@linaro.org> wrote: > > The tcg-op.h header was missing the usual guard against multiple > inclusion; add it. > > (Spotted by lgtm.com's static analyzer.) > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > tcg/tcg-op.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h > index 7513c1eb7c5..db4e9188f42 100644 > --- a/tcg/tcg-op.h > +++ b/tcg/tcg-op.h > @@ -22,6 +22,9 @@ > * THE SOFTWARE. > */ > > +#ifndef TCG_TCG_OP_H > +#define TCG_TCG_OP_H > + > #include "tcg.h" > #include "exec/helper-proto.h" > #include "exec/helper-gen.h" > @@ -1267,3 +1270,5 @@ static inline void tcg_gen_trunc_ptr_i32(TCGv_i32 r, TCGv_ptr a) > > #undef PTR > #undef NAT > + > +#endif /* TCG_TCG_OP_H */ > -- > 2.19.1 > > -- Marc-André Lureau
On 8/11/18 13:52, Peter Maydell wrote: > The tcg-op.h header was missing the usual guard against multiple > inclusion; add it. > > (Spotted by lgtm.com's static analyzer.) I'm pretty sure there are more occurences. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tcg/tcg-op.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h > index 7513c1eb7c5..db4e9188f42 100644 > --- a/tcg/tcg-op.h > +++ b/tcg/tcg-op.h > @@ -22,6 +22,9 @@ > * THE SOFTWARE. > */ > > +#ifndef TCG_TCG_OP_H > +#define TCG_TCG_OP_H > + > #include "tcg.h" > #include "exec/helper-proto.h" > #include "exec/helper-gen.h" > @@ -1267,3 +1270,5 @@ static inline void tcg_gen_trunc_ptr_i32(TCGv_i32 r, TCGv_ptr a) > > #undef PTR > #undef NAT > + > +#endif /* TCG_TCG_OP_H */ >
On 8 November 2018 at 13:08, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > On 8/11/18 13:52, Peter Maydell wrote: >> >> The tcg-op.h header was missing the usual guard against multiple >> inclusion; add it. >> >> (Spotted by lgtm.com's static analyzer.) > > > I'm pretty sure there are more occurences. The only other ones the analyzer spotted all seemed to be "deliberately multiply included" (like include/exec/memory_ldst_phys.inc.h), though we don't in all cases use the ".inc.h" convention that sort-of indicates that). https://lgtm.com/projects/g/qemu/qemu/alerts/?mode=tree is probably the most convenient url if you want to go looking for other stuff. Some of its issues are definitely false-positives, but there may be some other easy to fix things in there (eg the "local variable hides global variable" ones -- though if we care about these we should enable -Wshadow and fix the compile failures). Notably, lgtm does checks on python, which Coverity does not, so that is more likely to be a source of real issues to fix, I think. thanks -- PMM
On 11/8/18 1:52 PM, Peter Maydell wrote: > The tcg-op.h header was missing the usual guard against multiple > inclusion; add it. > > (Spotted by lgtm.com's static analyzer.) > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > tcg/tcg-op.h | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> FWIW, while I can queue this, I do not have any other outstanding tcg patches. So maybe just apply it to master directly? r~
On 8/11/18 14:17, Peter Maydell wrote: > On 8 November 2018 at 13:08, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >> On 8/11/18 13:52, Peter Maydell wrote: >>> >>> The tcg-op.h header was missing the usual guard against multiple >>> inclusion; add it. >>> >>> (Spotted by lgtm.com's static analyzer.) >> >> >> I'm pretty sure there are more occurences. > > The only other ones the analyzer spotted all seemed to be > "deliberately multiply included" (like > include/exec/memory_ldst_phys.inc.h), though we don't in > all cases use the ".inc.h" convention that sort-of > indicates that). > > https://lgtm.com/projects/g/qemu/qemu/alerts/?mode=tree > is probably the most convenient url if you want to > go looking for other stuff. Some of its issues are > definitely false-positives, but there may be some other > easy to fix things in there (eg the "local variable > hides global variable" ones -- though if we care about > these we should enable -Wshadow and fix the compile > failures). > > Notably, lgtm does checks on python, which Coverity does not, > so that is more likely to be a source of real issues to fix, > I think. Thanks for the pointer. This stats are funny^H^H^H^Hscary: https://lgtm.com/blog/best_email_domain#What%20about%20the%20free%20email%20providers? > > thanks > -- PMM >
On 8 November 2018 at 13:39, Richard Henderson <rth@twiddle.net> wrote: > On 11/8/18 1:52 PM, Peter Maydell wrote: >> The tcg-op.h header was missing the usual guard against multiple >> inclusion; add it. >> >> (Spotted by lgtm.com's static analyzer.) >> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> >> --- >> tcg/tcg-op.h | 5 +++++ >> 1 file changed, 5 insertions(+) > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > > FWIW, while I can queue this, I do not have any other outstanding tcg patches. > So maybe just apply it to master directly? OK, applied to master. -- PMM
diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index 7513c1eb7c5..db4e9188f42 100644 --- a/tcg/tcg-op.h +++ b/tcg/tcg-op.h @@ -22,6 +22,9 @@ * THE SOFTWARE. */ +#ifndef TCG_TCG_OP_H +#define TCG_TCG_OP_H + #include "tcg.h" #include "exec/helper-proto.h" #include "exec/helper-gen.h" @@ -1267,3 +1270,5 @@ static inline void tcg_gen_trunc_ptr_i32(TCGv_i32 r, TCGv_ptr a) #undef PTR #undef NAT + +#endif /* TCG_TCG_OP_H */
The tcg-op.h header was missing the usual guard against multiple inclusion; add it. (Spotted by lgtm.com's static analyzer.) Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- tcg/tcg-op.h | 5 +++++ 1 file changed, 5 insertions(+) -- 2.19.1